From b7c1b4c4a63f10dd906b5728a9bdb32dfc438581 Mon Sep 17 00:00:00 2001 From: Roman Telezhynskyi Date: Mon, 28 Oct 2019 14:52:49 +0200 Subject: [PATCH] Clazy warnings. --HG-- branch : develop --- src/app/valentina/core/vapplication.cpp | 8 ++++---- src/libs/vlayout/vlayoutpiece.cpp | 3 +++ 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/app/valentina/core/vapplication.cpp b/src/app/valentina/core/vapplication.cpp index dcaf81865..36e0d31b0 100644 --- a/src/app/valentina/core/vapplication.cpp +++ b/src/app/valentina/core/vapplication.cpp @@ -312,7 +312,7 @@ void VApplication::NewValentina(const QString &fileName) } else { - const QString run = QString("\"%1\" \"%2\"").arg(QCoreApplication::applicationFilePath(), fileName); + const QString run = QStringLiteral("\"%1\" \"%2\"").arg(QCoreApplication::applicationFilePath(), fileName); qCDebug(vApp, "New process with arguments. program = %s", qUtf8Printable(run)); if (QProcess::startDetached(run)) { @@ -409,7 +409,7 @@ void VApplication::ActivateDarkMode() VSettings *settings = qApp->ValentinaSettings(); if (settings->GetDarkMode()) { - QFile f(":qdarkstyle/style.qss"); + QFile f(QStringLiteral(":qdarkstyle/style.qss")); if (!f.exists()) { qDebug()<<"Unable to set stylesheet, file not found\n"; @@ -495,7 +495,7 @@ QString VApplication::LogDirPath() const //--------------------------------------------------------------------------------------------------------------------- QString VApplication::LogPath() const { - return QString("%1/valentina-pid%2.log").arg(LogDirPath()).arg(applicationPid()); + return QStringLiteral("%1/valentina-pid%2.log").arg(LogDirPath()).arg(applicationPid()); } //--------------------------------------------------------------------------------------------------------------------- @@ -615,7 +615,7 @@ void VApplication::InitOptions() //use an icon theme that we provide via a .qrc file //This case happens under Windows and Mac OS X //This does not happen under GNOME or KDE - QIcon::setThemeName("win.icon.theme"); + QIcon::setThemeName(QStringLiteral("win.icon.theme")); } ActivateDarkMode(); } diff --git a/src/libs/vlayout/vlayoutpiece.cpp b/src/libs/vlayout/vlayoutpiece.cpp index 1c7296d99..d4ac8d97a 100644 --- a/src/libs/vlayout/vlayoutpiece.cpp +++ b/src/libs/vlayout/vlayoutpiece.cpp @@ -73,6 +73,7 @@ QVector ConvertInternalPaths(const VPiece &piece, const VConta QVector paths; const QVector pathsId = piece.GetInternalPaths(); const QVector cuttingPath = piece.CuttingPathPoints(pattern); + paths.reserve(pathsId.size()); for (auto id : pathsId) { const VPiecePath path = pattern->GetPiecePath(id); @@ -204,6 +205,7 @@ QStringList PieceLabelText(const QVector &labelShape, const VTextManage QStringList text; if (labelShape.count() > 2) { + text.reserve(tm.GetSourceLinesCount()); for (int i = 0; i < tm.GetSourceLinesCount(); ++i) { text.append(tm.GetSourceLine(i).m_qsText); @@ -217,6 +219,7 @@ QVector ConvertPlaceLabels(const VPiece &piece, const VContai { QVector labels; const QVector placeLabels = piece.GetPlaceLabels(); + labels.reserve(placeLabels.size()); for(auto placeLabel : placeLabels) { const auto label = pattern->GeometricObject(placeLabel);