aw/valentina_old
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

SonarQube warnings.

Browse Source 
--HG--
branch : develop
This commit is contained in:
Roman Telezhynskyi 2017-06-05 19:47:25 +03:00
parent 8e7ea0f45f
commit 3a4871fcd0
5 changed files with 37 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
src/app/tape/dialogs/dialogmdatabase.cpp
View File

@ -177,7 +177,7 @@ QString DialogMDataBase::ImgTag(const QString &number)
const bool ok = renderer.load(filePath); const bool ok = renderer.load(filePath);
if (ok) if (ok)
{ {
const QScreen *screen = QApplication::screens().at(0); const QScreen *screen = QGuiApplication::screens().at(0);
if (screen) if (screen)
{ {
const QSize defSize = renderer.defaultSize(); const QSize defSize = renderer.defaultSize();
@ -223,30 +223,27 @@ void DialogMDataBase::changeEvent(QEvent *event)
//--------------------------------------------------------------------------------------------------------------------- //---------------------------------------------------------------------------------------------------------------------
bool DialogMDataBase::eventFilter(QObject *target, QEvent *event) bool DialogMDataBase::eventFilter(QObject *target, QEvent *event)
{ {
if (target == ui->treeWidget) if (target == ui->treeWidget && event->type() == QEvent::KeyPress)
{ {
if (event->type() == QEvent::KeyPress) QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event);
switch(keyEvent->key())
{ {
QKeyEvent *keyEvent = static_cast<QKeyEvent *>(event); case Qt::Key_Up:
switch(keyEvent->key())
{ {
case Qt::Key_Up: const QModelIndex model = ui->treeWidget->indexAbove(ui->treeWidget->currentIndex());
{ QTreeWidgetItem *item = ui->treeWidget->itemAbove(ui->treeWidget->currentItem());
const QModelIndex model = ui->treeWidget->indexAbove(ui->treeWidget->currentIndex()); ShowDescription(item, model.column());
QTreeWidgetItem *item = ui->treeWidget->itemAbove(ui->treeWidget->currentItem()); break;
ShowDescription(item, model.column());
break;
}
case Qt::Key_Down:
{
const QModelIndex model = ui->treeWidget->indexBelow(ui->treeWidget->currentIndex());
QTreeWidgetItem *item = ui->treeWidget->itemBelow(ui->treeWidget->currentItem());
ShowDescription(item, model.column());
break;
}
default:
break;
} }
case Qt::Key_Down:
{
const QModelIndex model = ui->treeWidget->indexBelow(ui->treeWidget->currentIndex());
QTreeWidgetItem *item = ui->treeWidget->itemBelow(ui->treeWidget->currentItem());
ShowDescription(item, model.column());
break;
}
default:
break;
} }
} }
return QDialog::eventFilter(target, event); return QDialog::eventFilter(target, event);

5
src/libs/qmuparser/qmuparserbase.cpp
View File

@ -143,7 +143,10 @@ QmuParserBase::~QmuParserBase()
*/ */
QmuParserBase& QmuParserBase::operator=(const QmuParserBase &a_Parser) QmuParserBase& QmuParserBase::operator=(const QmuParserBase &a_Parser)
{ {
Assign(a_Parser); if (this != &a_Parser)
{
Assign(a_Parser);
}
return *this; return *this;
} }

5
src/libs/qmuparser/qmuparserbytecode.cpp
View File

@ -64,7 +64,10 @@ QmuParserByteCode::QmuParserByteCode(const QmuParserByteCode &a_ByteCode)
*/ */
QmuParserByteCode& QmuParserByteCode::operator=(const QmuParserByteCode &a_ByteCode) QmuParserByteCode& QmuParserByteCode::operator=(const QmuParserByteCode &a_ByteCode)
{ {
Assign(a_ByteCode); if (this != &a_ByteCode)
{
Assign(a_ByteCode);
}
return *this; return *this;
} }

17
src/libs/qmuparser/qmuparsercallback.cpp
View File

@ -313,13 +313,16 @@ QmuParserCallback::QmuParserCallback (const QmuParserCallback &a_Fun )
//--------------------------------------------------------------------------------------------------------------------- //---------------------------------------------------------------------------------------------------------------------
QmuParserCallback &QmuParserCallback::operator=(const QmuParserCallback &a_Fun) QmuParserCallback &QmuParserCallback::operator=(const QmuParserCallback &a_Fun)
{ {
m_pFun = a_Fun.m_pFun; if (this != &a_Fun)
m_iArgc = a_Fun.m_iArgc; {
m_bAllowOpti = a_Fun.m_bAllowOpti; m_pFun = a_Fun.m_pFun;
m_iCode = a_Fun.m_iCode; m_iArgc = a_Fun.m_iArgc;
m_iType = a_Fun.m_iType; m_bAllowOpti = a_Fun.m_bAllowOpti;
m_iPri = a_Fun.m_iPri; m_iCode = a_Fun.m_iCode;
m_eOprtAsct = a_Fun.m_eOprtAsct; m_iType = a_Fun.m_iType;
m_iPri = a_Fun.m_iPri;
m_eOprtAsct = a_Fun.m_eOprtAsct;
}
return *this; return *this;
} }

2
src/libs/vpropertyexplorer/vpropertyexplorer.pro
View File

@ -8,7 +8,7 @@
include(../../../common.pri) include(../../../common.pri)
# Library use widgets # Library use widgets
QT += widgets QT += core widgets
# We don't need gui library. # We don't need gui library.
QT -= gui QT -= gui