Test unique id.

--HG--
branch : develop

Valentina.pro

@@ -95,7 +95,8 @@ SOURCES += main.cpp\
     exception/vexceptionconversionerror.cpp \
     exception/vexceptionemptyparameter.cpp \
     exception/vexceptionobjecterror.cpp \
-    widgets/vapplication.cpp
+    widgets/vapplication.cpp \
+    exception/vexceptionuniqueid.cpp
 
 HEADERS  += mainwindow.h \
     widgets/vmaingraphicsscene.h \
@@ -185,7 +186,8 @@ HEADERS  += mainwindow.h \
     exception/vexceptionconversionerror.h \
     exception/vexceptionemptyparameter.h \
     exception/vexceptionobjecterror.h \
-    widgets/vapplication.h
+    widgets/vapplication.h \
+    exception/vexceptionuniqueid.h
 
 FORMS    += mainwindow.ui \
     dialogs/dialogsinglepoint.ui \

exception/vexceptionemptyparameter.cpp

@@ -27,10 +27,8 @@ VExceptionEmptyParameter::VExceptionEmptyParameter(const QString &what, const QS
     name(name), tagText(QString()), tagName(QString()), lineNumber(-1){
     Q_ASSERT_X(!domElement.isNull(), Q_FUNC_INFO, "domElement is null");
     Q_ASSERT_X(!name.isEmpty(), Q_FUNC_INFO, "Parameter name is empty");
-    if(domElement.isText()){
+    QTextStream stream(&tagText);
-        QDomText text = domElement.toText();
+    domElement.save(stream, 4);
-        tagText = text.data();
-    }
     tagName = domElement.tagName();
     lineNumber = domElement.lineNumber();
 }

exception/vexceptionobjecterror.cpp

@@ -25,10 +25,8 @@
 VExceptionObjectError::VExceptionObjectError(const QString &what, const QDomElement &domElement):
     VException(what), tagText(QString()), tagName(QString()), lineNumber(-1), moreInfo(QString()){
     Q_ASSERT_X(!domElement.isNull(), Q_FUNC_INFO, "domElement is null");
-    if(domElement.isText()){
+    QTextStream stream(&tagText);
-        QDomText text = domElement.toText();
+    domElement.save(stream, 4);
-        tagText = text.data();
-    }
     tagName = domElement.tagName();
     lineNumber = domElement.lineNumber();
 }

exception/vexceptionuniqueid.cpp

@@ -0,0 +1,21 @@
+#include "vexceptionuniqueid.h"
+#include <QTextStream>
+
+VExceptionUniqueId::VExceptionUniqueId(const QString &what, const QDomElement &domElement)
+    :VException(what), tagText(QString()), tagName(QString()), lineNumber(-1){
+    Q_ASSERT_X(!domElement.isNull(), Q_FUNC_INFO, "domElement is null");
+    QTextStream stream(&tagText);
+    domElement.save(stream, 4);
+    tagName = domElement.tagName();
+    lineNumber = domElement.lineNumber();
+}
+
+QString VExceptionUniqueId::ErrorMessage() const{
+    QString error = QString("ExceptionUniqueId: %1").arg(what);
+    return error;
+}
+
+QString VExceptionUniqueId::DetailedInformation() const{
+    QString detail = QString("tag: %1 in line %2\nFull tag:\n%3").arg(tagName).arg(lineNumber).arg(tagText);
+    return detail;
+}

exception/vexceptionuniqueid.h

@@ -0,0 +1,24 @@
+#ifndef VEXCEPTIONUNIQUEID_H
+#define VEXCEPTIONUNIQUEID_H
+
+#include "vexception.h"
+#include <QDomElement>
+
+class VExceptionUniqueId : public VException{
+public:
+    VExceptionUniqueId(const QString &what, const QDomElement &domElement);
+    VExceptionUniqueId(const VExceptionUniqueId &e):VException(e), tagText(e.TagText()),
+        tagName(e.TagName()), lineNumber(e.LineNumber()){}
+    virtual ~VExceptionUniqueId() noexcept(true){}
+    virtual QString ErrorMessage() const;
+    virtual QString DetailedInformation() const;
+    QString TagText() const {return tagText;}
+    QString TagName() const {return tagName;}
+    qint32 LineNumber() const {return lineNumber;}
+protected:
+    QString tagText;
+    QString tagName;
+    qint32  lineNumber;
+};
+
+#endif // VEXCEPTIONUNIQUEID_H

exception/vexceptionwrongparameterid.cpp

@@ -25,10 +25,8 @@
 VExceptionWrongParameterId::VExceptionWrongParameterId(const QString &what, const QDomElement &domElement):
     VException(what), tagText(QString()), tagName(QString()), lineNumber(-1){
     Q_ASSERT_X(!domElement.isNull(), Q_FUNC_INFO, "domElement is null");
-    if(domElement.isText()){
+    QTextStream stream(&tagText);
-        QDomText text = domElement.toText();
+    domElement.save(stream, 4);
-        tagText = text.data();
-    }
     tagName = domElement.tagName();
     lineNumber = domElement.lineNumber();
 }

mainwindow.cpp

@@ -35,6 +35,7 @@
 #include "exception/vexceptionconversionerror.h"
 #include "exception/vexceptionemptyparameter.h"
 #include "exception/vexceptionwrongparameterid.h"
+#include "exception/vexceptionuniqueid.h"
 
 MainWindow::MainWindow(QWidget *parent) :
     QMainWindow(parent), ui(new Ui::MainWindow), tool(Tool::ArrowTool), currentScene(0), sceneDraw(0),
@@ -1070,6 +1071,20 @@ void MainWindow::OpenPattern(const QString &fileName){
                 Clear();
                 return;
             }
+            catch(const VExceptionUniqueId &e){
+                QMessageBox msgBox;
+                msgBox.setWindowTitle(tr("Error!"));
+                msgBox.setText(tr("Error don't unique id."));
+                msgBox.setInformativeText(e.ErrorMessage());
+                msgBox.setStandardButtons(QMessageBox::Ok);
+                msgBox.setDefaultButton(QMessageBox::Ok);
+                msgBox.setDetailedText(e.DetailedInformation());
+                msgBox.setIcon(QMessageBox::Critical);
+                msgBox.exec();
+                file.close();
+                Clear();
+                return;
+            }
             connect(comboBoxDraws,  static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
                     this, &MainWindow::currentDrawChanged);
             QString nameDraw = doc->GetNameActivDraw();

xml/vdomdocument.cpp

@@ -33,7 +33,7 @@
 #include "exception/vexceptionemptyparameter.h"
 #include "exception/vexceptionbadid.h"
 #include "exception/vexceptionobjecterror.h"
-
+#include "exception/vexceptionuniqueid.h"
 
 VDomDocument::VDomDocument(VContainer *data, QComboBox *comboBoxDraws, Draw::Draws *mode) : QDomDocument(),
     map(QHash<QString, QDomElement>()), nameActivDraw(QString()), data(data),
@@ -255,6 +255,7 @@ void VDomDocument::Parse(Document::Documents parse, VMainGraphicsScene *sceneDra
     Q_CHECK_PTR(sceneDraw);
     Q_CHECK_PTR(sceneDetail);
     if(parse == Document::FullParse){
+        TestUniqueId();
         data->Clear();
         nameActivDraw.clear();
         sceneDraw->clear();
@@ -370,6 +371,28 @@ qreal VDomDocument::GetParametrDouble(const QDomElement &domElement, const QStri
     return param;
 }
 
+void VDomDocument::TestUniqueId() const{
+    QVector<qint64> vector;
+    CollectId(this->documentElement(), vector);
+}
+
+void VDomDocument::CollectId(QDomElement node, QVector<qint64> &vector) const{
+    if (node.hasAttribute("id")) {
+        qint64 id = GetParametrId(node);
+        if(vector.contains(id)){
+            throw VExceptionUniqueId(tr("This id is not unique."), node);
+        }
+        vector.append(id);
+    }
+
+    for (qint32 i=0; i<node.childNodes().length(); ++i) {
+        QDomNode n = node.childNodes().at(i);
+        if (n.isElement()) {
+            CollectId(n.toElement(), vector);
+        }
+    }
+}
+
 void VDomDocument::ParseDrawElement(VMainGraphicsScene *sceneDraw, VMainGraphicsScene *sceneDetail,
                                     const QDomNode& node, const Document::Documents &parse){
     QDomNode domNode = node.firstChild();

xml/vdomdocument.h

@@ -37,8 +37,7 @@ Q_DECLARE_OPERATORS_FOR_FLAGS(Document::Documents)
 
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Weffc++"
-class VDomDocument : public QObject, public QDomDocument
+class VDomDocument : public QObject, public QDomDocument{
-{
     Q_OBJECT
 public:
                 VDomDocument(VContainer *data,QComboBox *comboBoxDraws, Draw::Draws *mode);
@@ -113,6 +112,8 @@ private:
     qint64      GetParametrLongLong(const QDomElement& domElement, const QString &name) const;
     QString     GetParametrString(const QDomElement& domElement, const QString &name) const;
     qreal       GetParametrDouble(const QDomElement& domElement, const QString &name) const;
+    void        TestUniqueId() const;
+    void        CollectId(QDomElement node, QVector<qint64> &vector)const;
 };
 
 #pragma GCC diagnostic pop