aw/valentina_old
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve translation test for supporting Greek language.

Browse Source 
The '?' in Greek language is ';'.

--HG--
branch : develop
This commit is contained in:
Roman Telezhynskyi 2016-10-25 19:11:26 +03:00
parent 214c4a50b6
commit 06eb7c3b75
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/test/TranslationsTest/tst_tstranslation.cpp
View File

@ -302,6 +302,7 @@ void TST_TSTranslation::TestPunctuation_data()
QVERIFY2(locales.size() == fileNames.size()-1, "Unexpected count of files."); QVERIFY2(locales.size() == fileNames.size()-1, "Unexpected count of files.");
} }
QTest::addColumn<QString>("locale");
QTest::addColumn<QString>("source"); QTest::addColumn<QString>("source");
QTest::addColumn<QString>("translation"); QTest::addColumn<QString>("translation");
@ -342,7 +343,7 @@ void TST_TSTranslation::TestPunctuation_data()
} }
const QString message = QString("File '%1'.").arg(filename); const QString message = QString("File '%1'.").arg(filename);
QTest::newRow(qUtf8Printable(message)) << source << translation; QTest::newRow(qUtf8Printable(message)) << locales.at(j) << source << translation;
} }
else else
{ {
@ -356,6 +357,7 @@ void TST_TSTranslation::TestPunctuation_data()
//--------------------------------------------------------------------------------------------------------------------- //---------------------------------------------------------------------------------------------------------------------
void TST_TSTranslation::TestPunctuation() void TST_TSTranslation::TestPunctuation()
{ {
QFETCH(QString, locale);
QFETCH(QString, source); QFETCH(QString, source);
QFETCH(QString, translation); QFETCH(QString, translation);
@ -364,21 +366,29 @@ void TST_TSTranslation::TestPunctuation()
<< QLatin1String(" ") << QLatin1String(" ")
<< QLatin1String("\n") << QLatin1String("\n")
<< QLatin1String("!") << QLatin1String("!")
<< QLatin1String("?"); << QLatin1String("?")
<< QLatin1String(";");
bool testFail = false; bool testFail = false;
QChar c = source.at(source.length()-1); const QChar cSource = source.at(source.length()-1);
if (punctuation.contains(c)) QChar cPunctuation = cSource;
const QChar cTranslation = translation.at(translation.length()-1);
if (punctuation.contains(cSource))
{ {
if (not (source.endsWith(c) && translation.endsWith(c))) if (not translation.endsWith(cSource))
{ {
testFail = true; testFail = true;
if (locale == QLatin1String("el_GR") && cSource == QLatin1Char('?') && cTranslation == QLatin1Char(';'))
{
testFail = false;
}
} }
} }
else else
{ {
c = translation.at(translation.length()-1); if (punctuation.contains(cTranslation))
if (punctuation.contains(c))
{ {
cPunctuation = cTranslation;
testFail = true; testFail = true;
} }
} }
@ -386,7 +396,7 @@ void TST_TSTranslation::TestPunctuation()
if (testFail) if (testFail)
{ {
const QString message = QString("Translation string does not end with the same punctuation character '%1' or " const QString message = QString("Translation string does not end with the same punctuation character '%1' or "
"vice versa. ").arg(c) + QString("Original name:'%1'").arg(source) + "vice versa. ").arg(cPunctuation) + QString("Original name:'%1'").arg(source) +
QString(", translated name:'%1'").arg(translation); QString(", translated name:'%1'").arg(translation);
QFAIL(qUtf8Printable(message)); QFAIL(qUtf8Printable(message));
} }