Sonarcloud warnings.

This commit is contained in:
Roman Telezhynskyi 2024-03-02 15:24:09 +02:00
parent 3548f2b71c
commit fb15284483
47 changed files with 115 additions and 113 deletions

View File

@ -47,7 +47,7 @@ class VPatternImage;
class QCompleter; class QCompleter;
class QxtCsvModel; class QxtCsvModel;
class TKMMainWindow : public VAbstractMainWindow class TKMMainWindow final : public VAbstractMainWindow
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -68,7 +68,7 @@ protected:
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto eventFilter(QObject *object, QEvent *event) -> bool override; auto eventFilter(QObject *object, QEvent *event) -> bool override;
void ExportToCSVData(const QString &fileName, bool withHeader, int mib, const QChar &separator) final; void ExportToCSVData(const QString &fileName, bool withHeader, int mib, const QChar &separator) override;
auto RecentFileList() const -> QStringList override; auto RecentFileList() const -> QStringList override;
private slots: private slots:

View File

@ -52,7 +52,7 @@ class QAbstractButton;
class QUuid; class QUuid;
class VKnownMeasurements; class VKnownMeasurements;
class TMainWindow : public VAbstractMainWindow class TMainWindow final : public VAbstractMainWindow
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -80,7 +80,7 @@ protected:
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto eventFilter(QObject *object, QEvent *event) -> bool override; auto eventFilter(QObject *object, QEvent *event) -> bool override;
void ExportToCSVData(const QString &fileName, bool withHeader, int mib, const QChar &separator) final; void ExportToCSVData(const QString &fileName, bool withHeader, int mib, const QChar &separator) override;
auto RecentFileList() const -> QStringList override; auto RecentFileList() const -> QStringList override;
private slots: private slots:
@ -295,7 +295,7 @@ private:
void SetCurrentDimensionValues(); void SetCurrentDimensionValues();
auto DimensionRestrictedValues(int index, const MeasurementDimension_p &dimension) -> QVector<double>; auto DimensionRestrictedValues(int index, const MeasurementDimension_p &dimension) -> QVector<double>;
auto OrderedMeasurements() const -> QMap<int, QSharedPointer<VMeasurement>>; auto OrderedMeasurements() const -> QMap<int, QSharedPointer<VMeasurement>>;
void InitIcons(); void InitIcons();

View File

@ -64,7 +64,7 @@ class VWidgetBackgroundImages;
/** /**
* @brief The MainWindow class main windows. * @brief The MainWindow class main windows.
*/ */
class MainWindow : public MainWindowsNoGUI class MainWindow final : public MainWindowsNoGUI
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -120,7 +120,7 @@ protected:
void customEvent(QEvent *event) override; void customEvent(QEvent *event) override;
void CleanLayout() override; void CleanLayout() override;
void PrepareSceneList(PreviewQuatilty quality) override; void PrepareSceneList(PreviewQuatilty quality) override;
void ExportToCSVData(const QString &fileName, bool withHeader, int mib, const QChar &separator) final; void ExportToCSVData(const QString &fileName, bool withHeader, int mib, const QChar &separator) override;
void ToolBarStyle(QToolBar *bar) const override; void ToolBarStyle(QToolBar *bar) const override;
private slots: private slots:
void ScaleChanged(qreal scale); void ScaleChanged(qreal scale);

View File

@ -152,7 +152,7 @@ auto PassmarkAngle(const VPiecePassmarkData &passmarkData, qreal angle) -> qreal
//--------------------------------------------------------------------------------------------------------------------- //---------------------------------------------------------------------------------------------------------------------
auto PassmarkWidth(const VPiecePassmarkData &passmarkData, qreal width) -> qreal auto PassmarkWidth(const VPiecePassmarkData &passmarkData, qreal width) -> qreal
{ {
auto ValidateWidth = [passmarkData](qreal width) auto ValidateWidth = [&passmarkData](qreal width)
{ {
if (qAbs(width) <= accuracyPointOnLine) if (qAbs(width) <= accuracyPointOnLine)
{ {

View File

@ -105,7 +105,7 @@ signals:
void DialogApplied(); void DialogApplied();
protected: protected:
virtual auto IsValid() const -> bool final; virtual auto IsValid() const -> bool;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void showEvent(QShowEvent *event) override; void showEvent(QShowEvent *event) override;
void resizeEvent(QResizeEvent *event) override; void resizeEvent(QResizeEvent *event) override;

View File

@ -96,7 +96,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogAlongLine) // NOLINT Q_DISABLE_COPY_MOVE(DialogAlongLine) // NOLINT

View File

@ -103,7 +103,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void ValidateAlias(); void ValidateAlias();

View File

@ -99,7 +99,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void ValidateAlias(); void ValidateAlias();

View File

@ -98,7 +98,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogBisector) // NOLINT Q_DISABLE_COPY_MOVE(DialogBisector) // NOLINT

View File

@ -44,12 +44,13 @@ namespace Ui
class DialogCubicBezier; class DialogCubicBezier;
} }
class DialogCubicBezier : public DialogTool class DialogCubicBezier final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
public: public:
explicit DialogCubicBezier(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr); explicit DialogCubicBezier(const VContainer *data, VAbstractPattern *doc, quint32 toolId,
QWidget *parent = nullptr);
~DialogCubicBezier() override; ~DialogCubicBezier() override;
auto GetSpline() const -> VCubicBezier; auto GetSpline() const -> VCubicBezier;
@ -68,7 +69,7 @@ protected:
* @brief SaveData Put dialog data in local variables * @brief SaveData Put dialog data in local variables
*/ */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void ValidateAlias(); void ValidateAlias();

View File

@ -45,7 +45,7 @@ namespace Ui
class DialogCubicBezierPath; class DialogCubicBezierPath;
} }
class DialogCubicBezierPath : public DialogTool class DialogCubicBezierPath final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -67,7 +67,7 @@ public slots:
protected: protected:
void ShowVisualization() override; void ShowVisualization() override;
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void PointChanged(int row); void PointChanged(int row);

View File

@ -93,7 +93,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void ValidateAlias(); void ValidateAlias();

View File

@ -92,7 +92,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void ArcChanged(); void ArcChanged();

View File

@ -90,7 +90,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void SplineChanged(); void SplineChanged();

View File

@ -90,7 +90,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void SplinePathChanged(); void SplinePathChanged();

View File

@ -42,7 +42,7 @@ namespace Ui
class DialogEllipticalArc; class DialogEllipticalArc;
} }
class DialogEllipticalArc : public DialogTool class DialogEllipticalArc final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -110,7 +110,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void ValidateAlias(); void ValidateAlias();

View File

@ -45,7 +45,7 @@ class DialogEndLine;
/** /**
* @brief The DialogEndLine class dialog for ToolEndLine. Help create point and edit option. * @brief The DialogEndLine class dialog for ToolEndLine. Help create point and edit option.
*/ */
class DialogEndLine : public DialogTool class DialogEndLine final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -97,7 +97,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogEndLine) // NOLINT Q_DISABLE_COPY_MOVE(DialogEndLine) // NOLINT

View File

@ -46,12 +46,13 @@ namespace Ui
class DialogFlippingByAxis; class DialogFlippingByAxis;
} }
class DialogFlippingByAxis : public DialogTool class DialogFlippingByAxis final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
public: public:
explicit DialogFlippingByAxis(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr); explicit DialogFlippingByAxis(const VContainer *data, VAbstractPattern *doc, quint32 toolId,
QWidget *parent = nullptr);
~DialogFlippingByAxis() override; ~DialogFlippingByAxis() override;
auto GetOriginPointId() const -> quint32; auto GetOriginPointId() const -> quint32;
@ -99,7 +100,7 @@ protected:
/** @brief SaveData Put dialog data in local variables */ /** @brief SaveData Put dialog data in local variables */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void PointChanged(); void PointChanged();

View File

@ -46,12 +46,13 @@ namespace Ui
class DialogFlippingByLine; class DialogFlippingByLine;
} }
class DialogFlippingByLine : public DialogTool class DialogFlippingByLine final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
public: public:
explicit DialogFlippingByLine(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr); explicit DialogFlippingByLine(const VContainer *data, VAbstractPattern *doc, quint32 toolId,
QWidget *parent = nullptr);
~DialogFlippingByLine() override; ~DialogFlippingByLine() override;
auto GetFirstLinePointId() const -> quint32; auto GetFirstLinePointId() const -> quint32;
@ -99,7 +100,7 @@ protected:
/** @brief SaveData Put dialog data in local variables */ /** @brief SaveData Put dialog data in local variables */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void PointChanged(); void PointChanged();

View File

@ -42,7 +42,7 @@ namespace Ui
class DialogGroup; class DialogGroup;
} }
class DialogGroup : public DialogTool class DialogGroup final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -66,7 +66,7 @@ public slots:
void SelectedObject(bool selected, quint32 object, quint32 tool) override; void SelectedObject(bool selected, quint32 object, quint32 tool) override;
protected: protected:
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void NameChanged(); void NameChanged();

View File

@ -84,7 +84,7 @@ protected:
* @brief SaveData Put dialog data in local variables * @brief SaveData Put dialog data in local variables
*/ */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogHeight) // NOLINT Q_DISABLE_COPY_MOVE(DialogHeight) // NOLINT

View File

@ -45,7 +45,7 @@ class DialogLine;
/** /**
* @brief The DialogLine class dialog for ToolLine. Help create line and edit option. * @brief The DialogLine class dialog for ToolLine. Help create line and edit option.
*/ */
class DialogLine : public DialogTool class DialogLine final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -78,7 +78,7 @@ protected:
* @brief SaveData Put dialog data in local variables * @brief SaveData Put dialog data in local variables
*/ */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogLine) // NOLINT Q_DISABLE_COPY_MOVE(DialogLine) // NOLINT

View File

@ -45,7 +45,7 @@ class DialogLineIntersect;
/** /**
* @brief The DialogLineIntersect class dialog for ToolLineIntersect. Help create point and edit option. * @brief The DialogLineIntersect class dialog for ToolLineIntersect. Help create point and edit option.
*/ */
class DialogLineIntersect : public DialogTool class DialogLineIntersect final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -82,7 +82,7 @@ protected:
* @brief SaveData Put dialog data in local variables * @brief SaveData Put dialog data in local variables
*/ */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogLineIntersect) // NOLINT Q_DISABLE_COPY_MOVE(DialogLineIntersect) // NOLINT

View File

@ -42,7 +42,7 @@ namespace Ui
class DialogLineIntersectAxis; class DialogLineIntersectAxis;
} }
class DialogLineIntersectAxis : public DialogTool class DialogLineIntersectAxis final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -91,7 +91,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogLineIntersectAxis) // NOLINT Q_DISABLE_COPY_MOVE(DialogLineIntersectAxis) // NOLINT

View File

@ -45,7 +45,7 @@ namespace Ui
class DialogMove; class DialogMove;
} }
class DialogMove : public DialogTool class DialogMove final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -115,7 +115,7 @@ protected:
/** @brief SaveData Put dialog data in local variables */ /** @brief SaveData Put dialog data in local variables */
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogMove) // NOLINT Q_DISABLE_COPY_MOVE(DialogMove) // NOLINT

View File

@ -45,7 +45,7 @@ class DialogNormal;
/** /**
* @brief The DialogNormal class dialog for ToolNormal. Help create point and edit option. * @brief The DialogNormal class dialog for ToolNormal. Help create point and edit option.
*/ */
class DialogNormal : public DialogTool class DialogNormal final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -97,7 +97,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogNormal) // NOLINT Q_DISABLE_COPY_MOVE(DialogNormal) // NOLINT

View File

@ -43,7 +43,7 @@ namespace Ui
class DialogPointFromArcAndTangent; class DialogPointFromArcAndTangent;
} }
class DialogPointFromArcAndTangent : public DialogTool class DialogPointFromArcAndTangent final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -76,7 +76,7 @@ protected:
* @brief SaveData Put dialog data in local variables * @brief SaveData Put dialog data in local variables
*/ */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogPointFromArcAndTangent) // NOLINT Q_DISABLE_COPY_MOVE(DialogPointFromArcAndTangent) // NOLINT

View File

@ -43,12 +43,13 @@ namespace Ui
class DialogPointFromCircleAndTangent; class DialogPointFromCircleAndTangent;
} }
class DialogPointFromCircleAndTangent : public DialogTool class DialogPointFromCircleAndTangent final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
public: public:
DialogPointFromCircleAndTangent(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr); DialogPointFromCircleAndTangent(const VContainer *data, VAbstractPattern *doc, quint32 toolId,
QWidget *parent = nullptr);
~DialogPointFromCircleAndTangent() override; ~DialogPointFromCircleAndTangent() override;
auto GetPointName() const -> QString; auto GetPointName() const -> QString;
@ -87,7 +88,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogPointFromCircleAndTangent) // NOLINT Q_DISABLE_COPY_MOVE(DialogPointFromCircleAndTangent) // NOLINT

View File

@ -45,7 +45,7 @@ class DialogPointOfContact;
/** /**
* @brief The DialogPointOfContact class dialog for ToolPointOfContact. Help create point and edit option. * @brief The DialogPointOfContact class dialog for ToolPointOfContact. Help create point and edit option.
*/ */
class DialogPointOfContact : public DialogTool class DialogPointOfContact final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -91,7 +91,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogPointOfContact) // NOLINT Q_DISABLE_COPY_MOVE(DialogPointOfContact) // NOLINT

View File

@ -45,7 +45,7 @@ class DialogPointOfIntersection;
/** /**
* @brief The DialogPointOfIntersection class dialog for ToolPointOfIntersection. Help create point and edit option. * @brief The DialogPointOfIntersection class dialog for ToolPointOfIntersection. Help create point and edit option.
*/ */
class DialogPointOfIntersection : public DialogTool class DialogPointOfIntersection final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -75,7 +75,7 @@ protected:
* @brief SaveData Put dialog data in local variables * @brief SaveData Put dialog data in local variables
*/ */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogPointOfIntersection) // NOLINT Q_DISABLE_COPY_MOVE(DialogPointOfIntersection) // NOLINT

View File

@ -43,7 +43,7 @@ namespace Ui
class DialogPointOfIntersectionArcs; class DialogPointOfIntersectionArcs;
} }
class DialogPointOfIntersectionArcs : public DialogTool class DialogPointOfIntersectionArcs final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -77,7 +77,7 @@ protected:
* @brief SaveData Put dialog data in local variables * @brief SaveData Put dialog data in local variables
*/ */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogPointOfIntersectionArcs) // NOLINT Q_DISABLE_COPY_MOVE(DialogPointOfIntersectionArcs) // NOLINT

View File

@ -43,12 +43,13 @@ namespace Ui
class DialogPointOfIntersectionCircles; class DialogPointOfIntersectionCircles;
} }
class DialogPointOfIntersectionCircles : public DialogTool class DialogPointOfIntersectionCircles final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
public: public:
DialogPointOfIntersectionCircles(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr); DialogPointOfIntersectionCircles(const VContainer *data, VAbstractPattern *doc, quint32 toolId,
QWidget *parent = nullptr);
~DialogPointOfIntersectionCircles() override; ~DialogPointOfIntersectionCircles() override;
auto GetPointName() const -> QString; auto GetPointName() const -> QString;
@ -95,7 +96,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogPointOfIntersectionCircles) // NOLINT Q_DISABLE_COPY_MOVE(DialogPointOfIntersectionCircles) // NOLINT

View File

@ -43,7 +43,7 @@ namespace Ui
class DialogPointOfIntersectionCurves; class DialogPointOfIntersectionCurves;
} }
class DialogPointOfIntersectionCurves : public DialogTool class DialogPointOfIntersectionCurves final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -92,7 +92,7 @@ protected:
* @brief SaveData Put dialog data in local variables * @brief SaveData Put dialog data in local variables
*/ */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void CurveChanged(); void CurveChanged();

View File

@ -45,7 +45,7 @@ namespace Ui
class DialogRotation; class DialogRotation;
} }
class DialogRotation : public DialogTool class DialogRotation final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -104,7 +104,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void PointChanged(); void PointChanged();

View File

@ -45,7 +45,7 @@ class DialogShoulderPoint;
/** /**
* @brief The DialogShoulderPoint class dialog for ToolShoulderPoint. Help create point and edit option. * @brief The DialogShoulderPoint class dialog for ToolShoulderPoint. Help create point and edit option.
*/ */
class DialogShoulderPoint : public DialogTool class DialogShoulderPoint final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -97,7 +97,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogShoulderPoint) // NOLINT Q_DISABLE_COPY_MOVE(DialogShoulderPoint) // NOLINT

View File

@ -45,7 +45,7 @@ class DialogSinglePoint;
/** /**
* @brief The DialogSinglePoint class dialog for ToolSinglePoint. Help create point and edit option. * @brief The DialogSinglePoint class dialog for ToolSinglePoint. Help create point and edit option.
*/ */
class DialogSinglePoint : public DialogTool class DialogSinglePoint final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -69,7 +69,7 @@ protected:
* @brief SaveData Put dialog data in local variables * @brief SaveData Put dialog data in local variables
*/ */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogSinglePoint) // NOLINT Q_DISABLE_COPY_MOVE(DialogSinglePoint) // NOLINT

View File

@ -47,7 +47,7 @@ class DialogSpline;
/** /**
* @brief The DialogSpline class dialog for ToolSpline. Help create spline and edit option. * @brief The DialogSpline class dialog for ToolSpline. Help create spline and edit option.
*/ */
class DialogSpline : public DialogTool class DialogSpline final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -74,7 +74,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void DeployAngle1TextEdit(); void DeployAngle1TextEdit();

View File

@ -48,7 +48,7 @@ class DialogSplinePath;
/** /**
* @brief The DialogSplinePath class dialog for ToolSplinePath. Help create spline path and edit option. * @brief The DialogSplinePath class dialog for ToolSplinePath. Help create spline path and edit option.
*/ */
class DialogSplinePath : public DialogTool class DialogSplinePath final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -72,7 +72,7 @@ protected:
void SaveData() override; void SaveData() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
void showEvent(QShowEvent *event) override; void showEvent(QShowEvent *event) override;
void resizeEvent(QResizeEvent *event) override; void resizeEvent(QResizeEvent *event) override;

View File

@ -45,7 +45,7 @@ class DialogTriangle;
/** /**
* @brief The DialogTriangle class dialog for ToolTriangle. Help create point and edit option. * @brief The DialogTriangle class dialog for ToolTriangle. Help create point and edit option.
*/ */
class DialogTriangle : public DialogTool class DialogTriangle final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -81,7 +81,7 @@ protected:
* @brief SaveData Put dialog data in local variables * @brief SaveData Put dialog data in local variables
*/ */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogTriangle) // NOLINT Q_DISABLE_COPY_MOVE(DialogTriangle) // NOLINT

View File

@ -42,7 +42,7 @@ namespace Ui
class DialogTrueDarts; class DialogTrueDarts;
} }
class DialogTrueDarts : public DialogTool class DialogTrueDarts final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -86,7 +86,7 @@ protected:
* @brief SaveData Put dialog data in local variables * @brief SaveData Put dialog data in local variables
*/ */
void SaveData() override; void SaveData() override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogTrueDarts) // NOLINT Q_DISABLE_COPY_MOVE(DialogTrueDarts) // NOLINT

View File

@ -34,31 +34,31 @@
namespace Ui namespace Ui
{ {
class DialogInsertNode; class DialogInsertNode;
} }
class DialogInsertNode : public DialogTool class DialogInsertNode final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
public: public:
explicit DialogInsertNode(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr); explicit DialogInsertNode(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr);
virtual ~DialogInsertNode(); ~DialogInsertNode() override;
virtual void SetPiecesList(const QVector<quint32> &list) override; void SetPiecesList(const QVector<quint32> &list) override;
auto GetPieceId() const -> quint32; auto GetPieceId() const -> quint32;
void SetPieceId(quint32 id); void SetPieceId(quint32 id);
auto GetNodes() const -> QVector<VPieceNode>; auto GetNodes() const -> QVector<VPieceNode>;
virtual void ShowDialog(bool click) override; void ShowDialog(bool click) override;
public slots: public slots:
virtual void SelectedObject(bool selected, quint32 object, quint32 tool) override; void SelectedObject(bool selected, quint32 object, quint32 tool) override;
protected: protected:
virtual auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void ShowContextMenu(const QPoint &pos); void ShowContextMenu(const QPoint &pos);

View File

@ -36,7 +36,7 @@ namespace Ui
class DialogPiecePath; class DialogPiecePath;
} }
class DialogPiecePath : public DialogTool class DialogPiecePath final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -63,11 +63,11 @@ public slots:
void ShowDialog(bool click) override; void ShowDialog(bool click) override;
protected: protected:
void CheckState() final; void CheckState() override;
void ShowVisualization() override; void ShowVisualization() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void ShowContextMenu(const QPoint &pos); void ShowContextMenu(const QPoint &pos);

View File

@ -33,32 +33,33 @@
namespace Ui namespace Ui
{ {
class DialogPin; class DialogPin;
} }
class DialogPin : public DialogTool class DialogPin final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
public: public:
explicit DialogPin(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr); explicit DialogPin(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr);
virtual ~DialogPin(); ~DialogPin() override;
void EnbleShowMode(bool disable); void EnbleShowMode(bool disable);
auto GetPieceId() const -> quint32; auto GetPieceId() const -> quint32;
void SetPieceId(quint32 id); void SetPieceId(quint32 id);
auto GetPointId() const -> quint32; auto GetPointId() const -> quint32;
void SetPointId(quint32 id); void SetPointId(quint32 id);
virtual void SetPiecesList(const QVector<quint32> &list) override; void SetPiecesList(const QVector<quint32> &list) override;
public slots: public slots:
virtual void ChosenObject(quint32 id, const SceneObject &type) override; void ChosenObject(quint32 id, const SceneObject &type) override;
protected: protected:
virtual void ShowVisualization() override; void ShowVisualization() override;
virtual auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private: private:
Q_DISABLE_COPY_MOVE(DialogPin) // NOLINT Q_DISABLE_COPY_MOVE(DialogPin) // NOLINT

View File

@ -37,7 +37,7 @@ class DialogPlaceLabel;
class VPlaceLabelItem; class VPlaceLabelItem;
class DialogPlaceLabel : public DialogTool class DialogPlaceLabel final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -80,7 +80,7 @@ protected:
void ShowVisualization() override; void ShowVisualization() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
private slots: private slots:
void DeployFormulaWidthEdit(); void DeployFormulaWidthEdit();

View File

@ -50,7 +50,7 @@ class VisPieceSpecialPoints;
class FancyTabBar; class FancyTabBar;
class VUndoCommand; class VUndoCommand;
class DialogSeamAllowance : public DialogTool class DialogSeamAllowance final : public DialogTool
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -74,13 +74,13 @@ public slots:
protected: protected:
/** @brief SaveData Put dialog data in local variables */ /** @brief SaveData Put dialog data in local variables */
void SaveData() override; void SaveData() override;
void CheckState() final; void CheckState() override;
void closeEvent(QCloseEvent *event) override; void closeEvent(QCloseEvent *event) override;
void showEvent(QShowEvent *event) override; void showEvent(QShowEvent *event) override;
void resizeEvent(QResizeEvent *event) override; void resizeEvent(QResizeEvent *event) override;
void changeEvent(QEvent *event) override; void changeEvent(QEvent *event) override;
auto IsValid() const -> bool final; auto IsValid() const -> bool override;
void SetPatternDoc(VAbstractPattern *doc) final; void SetPatternDoc(VAbstractPattern *doc) override;
private slots: private slots:
void NameDetailChanged(); void NameDetailChanged();

View File

@ -55,13 +55,9 @@
struct VDrawToolInitData : VAbstractToolInitData struct VDrawToolInitData : VAbstractToolInitData
{ {
VDrawToolInitData() VDrawToolInitData() = default;
: VAbstractToolInitData(),
notes()
{
}
QString notes; QString notes{};
}; };
/** /**
@ -73,7 +69,7 @@ class VDrawTool : public VInteractiveTool
public: public:
VDrawTool(VAbstractPattern *doc, VContainer *data, quint32 id, const QString &notes, QObject *parent = nullptr); VDrawTool(VAbstractPattern *doc, VContainer *data, quint32 id, const QString &notes, QObject *parent = nullptr);
virtual ~VDrawTool() = default; ~VDrawTool() override = default;
auto getLineType() const -> QString; auto getLineType() const -> QString;
virtual void SetLineType(const QString &value); virtual void SetLineType(const QString &value);
@ -122,10 +118,10 @@ protected:
/** @brief SaveDialog save options into file after change in dialog. */ /** @brief SaveDialog save options into file after change in dialog. */
virtual void SaveDialog(QDomElement &domElement, QList<quint32> &oldDependencies, virtual void SaveDialog(QDomElement &domElement, QList<quint32> &oldDependencies,
QList<quint32> &newDependencies) = 0; QList<quint32> &newDependencies) = 0;
virtual void SaveDialogChange(const QString &undoText = QString()) final; void SaveDialogChange(const QString &undoText = QString()) final;
virtual void ApplyToolOptions(const QList<quint32> &oldDependencies, const QList<quint32> &newDependencies, virtual void ApplyToolOptions(const QList<quint32> &oldDependencies, const QList<quint32> &newDependencies,
const QDomElement &oldDomElement, const QDomElement &newDomElement); const QDomElement &oldDomElement, const QDomElement &newDomElement);
virtual void AddToFile() override; void AddToFile() override;
void SaveOption(QSharedPointer<VGObject> &obj); void SaveOption(QSharedPointer<VGObject> &obj);
virtual void SaveOptions(QDomElement &tag, QSharedPointer<VGObject> &obj); virtual void SaveOptions(QDomElement &tag, QSharedPointer<VGObject> &obj);
virtual auto MakeToolTip() const -> QString; virtual auto MakeToolTip() const -> QString;

View File

@ -50,7 +50,7 @@ struct VToolSeamAllowanceInitData : VAbstractToolInitData
QString drawName{}; // NOLINT(misc-non-private-member-variables-in-classes) QString drawName{}; // NOLINT(misc-non-private-member-variables-in-classes)
}; };
class VToolSeamAllowance : public VInteractiveTool, public QGraphicsPathItem class VToolSeamAllowance final : public VInteractiveTool, public QGraphicsPathItem
{ {
Q_OBJECT // NOLINT Q_OBJECT // NOLINT
@ -161,8 +161,8 @@ protected:
void SetVisualization() override {} void SetVisualization() override {}
void DeleteToolWithConfirm(bool ask = true) override; void DeleteToolWithConfirm(bool ask = true) override;
void ToolCreation(const Source &typeCreation) override; void ToolCreation(const Source &typeCreation) override;
void SetDialog() final; void SetDialog() override;
void SaveDialogChange(const QString &undoText = QString()) final; void SaveDialogChange(const QString &undoText = QString()) override;
private slots: private slots:
void ToggleInLayout(bool checked); void ToggleInLayout(bool checked);