Sonarcloud warnings.

src/app/tape/tkmmainwindow.h

@@ -47,7 +47,7 @@ class VPatternImage;
 class QCompleter;
 class QxtCsvModel;
 
-class TKMMainWindow : public VAbstractMainWindow
+class TKMMainWindow final : public VAbstractMainWindow
 {
     Q_OBJECT // NOLINT
 
@@ -68,7 +68,7 @@ protected:
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
     auto eventFilter(QObject *object, QEvent *event) -> bool override;
-    void ExportToCSVData(const QString &fileName, bool withHeader, int mib, const QChar &separator) final;
+    void ExportToCSVData(const QString &fileName, bool withHeader, int mib, const QChar &separator) override;
     auto RecentFileList() const -> QStringList override;
 
 private slots:

src/app/tape/tmainwindow.h

@@ -52,7 +52,7 @@ class QAbstractButton;
 class QUuid;
 class VKnownMeasurements;
 
-class TMainWindow : public VAbstractMainWindow
+class TMainWindow final : public VAbstractMainWindow
 {
     Q_OBJECT // NOLINT
 
@@ -80,7 +80,7 @@ protected:
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
     auto eventFilter(QObject *object, QEvent *event) -> bool override;
-    void ExportToCSVData(const QString &fileName, bool withHeader, int mib, const QChar &separator) final;
+    void ExportToCSVData(const QString &fileName, bool withHeader, int mib, const QChar &separator) override;
     auto RecentFileList() const -> QStringList override;
 
 private slots:

src/app/valentina/mainwindow.h

@@ -64,7 +64,7 @@ class VWidgetBackgroundImages;
 /**
  * @brief The MainWindow class main windows.
  */
-class MainWindow : public MainWindowsNoGUI
+class MainWindow final : public MainWindowsNoGUI
 {
     Q_OBJECT // NOLINT
 
@@ -120,7 +120,7 @@ protected:
     void customEvent(QEvent *event) override;
     void CleanLayout() override;
     void PrepareSceneList(PreviewQuatilty quality) override;
-    void ExportToCSVData(const QString &fileName, bool withHeader, int mib, const QChar &separator) final;
+    void ExportToCSVData(const QString &fileName, bool withHeader, int mib, const QChar &separator) override;
     void ToolBarStyle(QToolBar *bar) const override;
 private slots:
     void ScaleChanged(qreal scale);

src/libs/vpatterndb/vpassmark.cpp

@@ -152,7 +152,7 @@ auto PassmarkAngle(const VPiecePassmarkData &passmarkData, qreal angle) -> qreal
 //---------------------------------------------------------------------------------------------------------------------
 auto PassmarkWidth(const VPiecePassmarkData &passmarkData, qreal width) -> qreal
 {
-    auto ValidateWidth = [passmarkData](qreal width)
+    auto ValidateWidth = [&passmarkData](qreal width)
     {
         if (qAbs(width) <= accuracyPointOnLine)
         {

src/libs/vtools/dialogs/support/dialogeditwrongformula.h

@@ -105,7 +105,7 @@ signals:
     void DialogApplied();
 
 protected:
-    virtual auto IsValid() const -> bool final;
+    virtual auto IsValid() const -> bool;
     void closeEvent(QCloseEvent *event) override;
     void showEvent(QShowEvent *event) override;
     void resizeEvent(QResizeEvent *event) override;

src/libs/vtools/dialogs/tools/dialogalongline.h

@@ -96,7 +96,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogAlongLine) // NOLINT

src/libs/vtools/dialogs/tools/dialogarc.h

@@ -103,7 +103,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void ValidateAlias();

src/libs/vtools/dialogs/tools/dialogarcwithlength.h

@@ -99,7 +99,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void ValidateAlias();

src/libs/vtools/dialogs/tools/dialogbisector.h

@@ -98,7 +98,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogBisector) // NOLINT

src/libs/vtools/dialogs/tools/dialogcubicbezier.h

@@ -44,12 +44,13 @@ namespace Ui
 class DialogCubicBezier;
 }
 
-class DialogCubicBezier : public DialogTool
+class DialogCubicBezier final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
 public:
-    explicit DialogCubicBezier(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr);
+    explicit DialogCubicBezier(const VContainer *data, VAbstractPattern *doc, quint32 toolId,
+                               QWidget *parent = nullptr);
     ~DialogCubicBezier() override;
 
     auto GetSpline() const -> VCubicBezier;
@@ -68,7 +69,7 @@ protected:
      * @brief SaveData Put dialog data in local variables
      */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void ValidateAlias();

src/libs/vtools/dialogs/tools/dialogcubicbezierpath.h

@@ -45,7 +45,7 @@ namespace Ui
 class DialogCubicBezierPath;
 }
 
-class DialogCubicBezierPath : public DialogTool
+class DialogCubicBezierPath final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -67,7 +67,7 @@ public slots:
 protected:
     void ShowVisualization() override;
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void PointChanged(int row);

src/libs/vtools/dialogs/tools/dialogcurveintersectaxis.h

@@ -93,7 +93,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void ValidateAlias();

src/libs/vtools/dialogs/tools/dialogcutarc.h

@@ -92,7 +92,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void ArcChanged();

src/libs/vtools/dialogs/tools/dialogcutspline.h

@@ -90,7 +90,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void SplineChanged();

src/libs/vtools/dialogs/tools/dialogcutsplinepath.h

@@ -90,7 +90,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void SplinePathChanged();

src/libs/vtools/dialogs/tools/dialogellipticalarc.h

@@ -42,7 +42,7 @@ namespace Ui
 class DialogEllipticalArc;
 }
 
-class DialogEllipticalArc : public DialogTool
+class DialogEllipticalArc final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -110,7 +110,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void ValidateAlias();

src/libs/vtools/dialogs/tools/dialogendline.h

@@ -45,7 +45,7 @@ class DialogEndLine;
 /**
  * @brief The DialogEndLine class dialog for ToolEndLine. Help create point and edit option.
  */
-class DialogEndLine : public DialogTool
+class DialogEndLine final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -97,7 +97,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogEndLine) // NOLINT

src/libs/vtools/dialogs/tools/dialogflippingbyaxis.h

@@ -46,12 +46,13 @@ namespace Ui
 class DialogFlippingByAxis;
 }
 
-class DialogFlippingByAxis : public DialogTool
+class DialogFlippingByAxis final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
 public:
-    explicit DialogFlippingByAxis(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr);
+    explicit DialogFlippingByAxis(const VContainer *data, VAbstractPattern *doc, quint32 toolId,
+                                  QWidget *parent = nullptr);
     ~DialogFlippingByAxis() override;
 
     auto GetOriginPointId() const -> quint32;
@@ -99,7 +100,7 @@ protected:
 
     /** @brief SaveData Put dialog data in local variables */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void PointChanged();

src/libs/vtools/dialogs/tools/dialogflippingbyline.h

@@ -46,12 +46,13 @@ namespace Ui
 class DialogFlippingByLine;
 }
 
-class DialogFlippingByLine : public DialogTool
+class DialogFlippingByLine final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
 public:
-    explicit DialogFlippingByLine(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr);
+    explicit DialogFlippingByLine(const VContainer *data, VAbstractPattern *doc, quint32 toolId,
+                                  QWidget *parent = nullptr);
     ~DialogFlippingByLine() override;
 
     auto GetFirstLinePointId() const -> quint32;
@@ -99,7 +100,7 @@ protected:
 
     /** @brief SaveData Put dialog data in local variables */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void PointChanged();

src/libs/vtools/dialogs/tools/dialoggroup.h

@@ -42,7 +42,7 @@ namespace Ui
 class DialogGroup;
 }
 
-class DialogGroup : public DialogTool
+class DialogGroup final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -66,7 +66,7 @@ public slots:
     void SelectedObject(bool selected, quint32 object, quint32 tool) override;
 
 protected:
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void NameChanged();

src/libs/vtools/dialogs/tools/dialogheight.h

@@ -84,7 +84,7 @@ protected:
      * @brief SaveData Put dialog data in local variables
      */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogHeight) // NOLINT

src/libs/vtools/dialogs/tools/dialogline.h

@@ -45,7 +45,7 @@ class DialogLine;
 /**
  * @brief The DialogLine class dialog for ToolLine. Help create line and edit option.
  */
-class DialogLine : public DialogTool
+class DialogLine final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -78,7 +78,7 @@ protected:
      * @brief SaveData Put dialog data in local variables
      */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogLine) // NOLINT

src/libs/vtools/dialogs/tools/dialoglineintersect.h

@@ -45,7 +45,7 @@ class DialogLineIntersect;
 /**
  * @brief The DialogLineIntersect class dialog for ToolLineIntersect. Help create point and edit option.
  */
-class DialogLineIntersect : public DialogTool
+class DialogLineIntersect final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -82,7 +82,7 @@ protected:
      * @brief SaveData Put dialog data in local variables
      */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogLineIntersect) // NOLINT

src/libs/vtools/dialogs/tools/dialoglineintersectaxis.h

@@ -42,7 +42,7 @@ namespace Ui
 class DialogLineIntersectAxis;
 }
 
-class DialogLineIntersectAxis : public DialogTool
+class DialogLineIntersectAxis final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -91,7 +91,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogLineIntersectAxis) // NOLINT

src/libs/vtools/dialogs/tools/dialogmove.h

@@ -45,7 +45,7 @@ namespace Ui
 class DialogMove;
 }
 
-class DialogMove : public DialogTool
+class DialogMove final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -115,7 +115,7 @@ protected:
     /** @brief SaveData Put dialog data in local variables */
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogMove) // NOLINT

src/libs/vtools/dialogs/tools/dialognormal.h

@@ -45,7 +45,7 @@ class DialogNormal;
 /**
  * @brief The DialogNormal class dialog for ToolNormal. Help create point and edit option.
  */
-class DialogNormal : public DialogTool
+class DialogNormal final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -97,7 +97,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogNormal) // NOLINT

src/libs/vtools/dialogs/tools/dialogpointfromarcandtangent.h

@@ -43,7 +43,7 @@ namespace Ui
 class DialogPointFromArcAndTangent;
 }
 
-class DialogPointFromArcAndTangent : public DialogTool
+class DialogPointFromArcAndTangent final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -76,7 +76,7 @@ protected:
      * @brief SaveData Put dialog data in local variables
      */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogPointFromArcAndTangent) // NOLINT

src/libs/vtools/dialogs/tools/dialogpointfromcircleandtangent.h

@@ -43,12 +43,13 @@ namespace Ui
 class DialogPointFromCircleAndTangent;
 }
 
-class DialogPointFromCircleAndTangent : public DialogTool
+class DialogPointFromCircleAndTangent final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
 public:
-    DialogPointFromCircleAndTangent(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr);
+    DialogPointFromCircleAndTangent(const VContainer *data, VAbstractPattern *doc, quint32 toolId,
+                                    QWidget *parent = nullptr);
     ~DialogPointFromCircleAndTangent() override;
 
     auto GetPointName() const -> QString;
@@ -87,7 +88,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogPointFromCircleAndTangent) // NOLINT

src/libs/vtools/dialogs/tools/dialogpointofcontact.h

@@ -45,7 +45,7 @@ class DialogPointOfContact;
 /**
  * @brief The DialogPointOfContact class dialog for ToolPointOfContact. Help create point and edit option.
  */
-class DialogPointOfContact : public DialogTool
+class DialogPointOfContact final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -91,7 +91,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogPointOfContact) // NOLINT

src/libs/vtools/dialogs/tools/dialogpointofintersection.h

@@ -45,7 +45,7 @@ class DialogPointOfIntersection;
 /**
  * @brief The DialogPointOfIntersection class dialog for ToolPointOfIntersection. Help create point and edit option.
  */
-class DialogPointOfIntersection : public DialogTool
+class DialogPointOfIntersection final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -75,7 +75,7 @@ protected:
      * @brief SaveData Put dialog data in local variables
      */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogPointOfIntersection) // NOLINT

src/libs/vtools/dialogs/tools/dialogpointofintersectionarcs.h

@@ -43,7 +43,7 @@ namespace Ui
 class DialogPointOfIntersectionArcs;
 }
 
-class DialogPointOfIntersectionArcs : public DialogTool
+class DialogPointOfIntersectionArcs final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -77,7 +77,7 @@ protected:
      * @brief SaveData Put dialog data in local variables
      */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogPointOfIntersectionArcs) // NOLINT

src/libs/vtools/dialogs/tools/dialogpointofintersectioncircles.h

@@ -43,12 +43,13 @@ namespace Ui
 class DialogPointOfIntersectionCircles;
 }
 
-class DialogPointOfIntersectionCircles : public DialogTool
+class DialogPointOfIntersectionCircles final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
 public:
-    DialogPointOfIntersectionCircles(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr);
+    DialogPointOfIntersectionCircles(const VContainer *data, VAbstractPattern *doc, quint32 toolId,
+                                     QWidget *parent = nullptr);
     ~DialogPointOfIntersectionCircles() override;
 
     auto GetPointName() const -> QString;
@@ -95,7 +96,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogPointOfIntersectionCircles) // NOLINT

src/libs/vtools/dialogs/tools/dialogpointofintersectioncurves.h

@@ -43,7 +43,7 @@ namespace Ui
 class DialogPointOfIntersectionCurves;
 }
 
-class DialogPointOfIntersectionCurves : public DialogTool
+class DialogPointOfIntersectionCurves final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -92,7 +92,7 @@ protected:
      * @brief SaveData Put dialog data in local variables
      */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void CurveChanged();

src/libs/vtools/dialogs/tools/dialogrotation.h

@@ -45,7 +45,7 @@ namespace Ui
 class DialogRotation;
 }
 
-class DialogRotation : public DialogTool
+class DialogRotation final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -104,7 +104,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void PointChanged();

src/libs/vtools/dialogs/tools/dialogshoulderpoint.h

@@ -45,7 +45,7 @@ class DialogShoulderPoint;
 /**
  * @brief The DialogShoulderPoint class dialog for ToolShoulderPoint. Help create point and edit option.
  */
-class DialogShoulderPoint : public DialogTool
+class DialogShoulderPoint final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -97,7 +97,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogShoulderPoint) // NOLINT

src/libs/vtools/dialogs/tools/dialogsinglepoint.h

@@ -45,7 +45,7 @@ class DialogSinglePoint;
 /**
  * @brief The DialogSinglePoint class dialog for ToolSinglePoint. Help create point and edit option.
  */
-class DialogSinglePoint : public DialogTool
+class DialogSinglePoint final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -69,7 +69,7 @@ protected:
      * @brief SaveData Put dialog data in local variables
      */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogSinglePoint) // NOLINT

src/libs/vtools/dialogs/tools/dialogspline.h

@@ -47,7 +47,7 @@ class DialogSpline;
 /**
  * @brief The DialogSpline class dialog for ToolSpline. Help create spline and edit option.
  */
-class DialogSpline : public DialogTool
+class DialogSpline final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -74,7 +74,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void DeployAngle1TextEdit();

src/libs/vtools/dialogs/tools/dialogsplinepath.h

@@ -48,7 +48,7 @@ class DialogSplinePath;
 /**
  * @brief The DialogSplinePath class dialog for ToolSplinePath. Help create spline path and edit option.
  */
-class DialogSplinePath : public DialogTool
+class DialogSplinePath final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -72,7 +72,7 @@ protected:
     void SaveData() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
     void showEvent(QShowEvent *event) override;
     void resizeEvent(QResizeEvent *event) override;
 

src/libs/vtools/dialogs/tools/dialogtriangle.h

@@ -45,7 +45,7 @@ class DialogTriangle;
 /**
  * @brief The DialogTriangle class dialog for ToolTriangle. Help create point and edit option.
  */
-class DialogTriangle : public DialogTool
+class DialogTriangle final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -81,7 +81,7 @@ protected:
      * @brief SaveData Put dialog data in local variables
      */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogTriangle) // NOLINT

src/libs/vtools/dialogs/tools/dialogtruedarts.h

@@ -42,7 +42,7 @@ namespace Ui
 class DialogTrueDarts;
 }
 
-class DialogTrueDarts : public DialogTool
+class DialogTrueDarts final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -86,7 +86,7 @@ protected:
      * @brief SaveData Put dialog data in local variables
      */
     void SaveData() override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogTrueDarts) // NOLINT

src/libs/vtools/dialogs/tools/piece/dialoginsertnode.h

@@ -34,31 +34,31 @@
 
 namespace Ui
 {
-    class DialogInsertNode;
+class DialogInsertNode;
 }
 
-class DialogInsertNode : public DialogTool
+class DialogInsertNode final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
 public:
     explicit DialogInsertNode(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr);
-    virtual ~DialogInsertNode();
+    ~DialogInsertNode() override;
 
-    virtual void SetPiecesList(const QVector<quint32> &list) override;
+    void SetPiecesList(const QVector<quint32> &list) override;
 
     auto GetPieceId() const -> quint32;
     void SetPieceId(quint32 id);
 
     auto GetNodes() const -> QVector<VPieceNode>;
 
-    virtual void ShowDialog(bool click) override;
+    void ShowDialog(bool click) override;
 
 public slots:
-    virtual void SelectedObject(bool selected, quint32 object, quint32 tool) override;
+    void SelectedObject(bool selected, quint32 object, quint32 tool) override;
 
 protected:
-    virtual auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void ShowContextMenu(const QPoint &pos);

src/libs/vtools/dialogs/tools/piece/dialogpiecepath.h

@@ -36,7 +36,7 @@ namespace Ui
 class DialogPiecePath;
 }
 
-class DialogPiecePath : public DialogTool
+class DialogPiecePath final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -63,11 +63,11 @@ public slots:
     void ShowDialog(bool click) override;
 
 protected:
-    void CheckState() final;
+    void CheckState() override;
     void ShowVisualization() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void ShowContextMenu(const QPoint &pos);

src/libs/vtools/dialogs/tools/piece/dialogpin.h

@@ -33,15 +33,16 @@
 
 namespace Ui
 {
-    class DialogPin;
+class DialogPin;
 }
 
-class DialogPin : public DialogTool
+class DialogPin final : public DialogTool
 {
     Q_OBJECT // NOLINT
+
 public:
     explicit DialogPin(const VContainer *data, VAbstractPattern *doc, quint32 toolId, QWidget *parent = nullptr);
-    virtual ~DialogPin();
+    ~DialogPin() override;
 
     void EnbleShowMode(bool disable);
 
@@ -51,14 +52,14 @@ public:
     auto GetPointId() const -> quint32;
     void SetPointId(quint32 id);
 
-    virtual void SetPiecesList(const QVector<quint32> &list) override;
+    void SetPiecesList(const QVector<quint32> &list) override;
 
 public slots:
-    virtual void ChosenObject(quint32 id, const SceneObject &type) override;
+    void ChosenObject(quint32 id, const SceneObject &type) override;
 
 protected:
-    virtual void ShowVisualization() override;
+    void ShowVisualization() override;
-    virtual auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private:
     Q_DISABLE_COPY_MOVE(DialogPin) // NOLINT

src/libs/vtools/dialogs/tools/piece/dialogplacelabel.h

@@ -37,7 +37,7 @@ class DialogPlaceLabel;
 
 class VPlaceLabelItem;
 
-class DialogPlaceLabel : public DialogTool
+class DialogPlaceLabel final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -80,7 +80,7 @@ protected:
     void ShowVisualization() override;
     void closeEvent(QCloseEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
 
 private slots:
     void DeployFormulaWidthEdit();

src/libs/vtools/dialogs/tools/piece/dialogseamallowance.h

@@ -50,7 +50,7 @@ class VisPieceSpecialPoints;
 class FancyTabBar;
 class VUndoCommand;
 
-class DialogSeamAllowance : public DialogTool
+class DialogSeamAllowance final : public DialogTool
 {
     Q_OBJECT // NOLINT
 
@@ -74,13 +74,13 @@ public slots:
 protected:
     /** @brief SaveData Put dialog data in local variables */
     void SaveData() override;
-    void CheckState() final;
+    void CheckState() override;
     void closeEvent(QCloseEvent *event) override;
     void showEvent(QShowEvent *event) override;
     void resizeEvent(QResizeEvent *event) override;
     void changeEvent(QEvent *event) override;
-    auto IsValid() const -> bool final;
+    auto IsValid() const -> bool override;
-    void SetPatternDoc(VAbstractPattern *doc) final;
+    void SetPatternDoc(VAbstractPattern *doc) override;
 
 private slots:
     void NameDetailChanged();

src/libs/vtools/tools/drawTools/vdrawtool.h

@@ -55,13 +55,9 @@
 
 struct VDrawToolInitData : VAbstractToolInitData
 {
-    VDrawToolInitData()
+    VDrawToolInitData() = default;
-      : VAbstractToolInitData(),
-        notes()
-    {
-    }
 
-    QString notes;
+    QString notes{};
 };
 
 /**
@@ -73,7 +69,7 @@ class VDrawTool : public VInteractiveTool
 
 public:
     VDrawTool(VAbstractPattern *doc, VContainer *data, quint32 id, const QString &notes, QObject *parent = nullptr);
-    virtual ~VDrawTool() = default;
+    ~VDrawTool() override = default;
 
     auto getLineType() const -> QString;
     virtual void SetLineType(const QString &value);
@@ -122,10 +118,10 @@ protected:
     /** @brief SaveDialog save options into file after change in dialog. */
     virtual void SaveDialog(QDomElement &domElement, QList<quint32> &oldDependencies,
                             QList<quint32> &newDependencies) = 0;
-    virtual void SaveDialogChange(const QString &undoText = QString()) final;
+    void SaveDialogChange(const QString &undoText = QString()) final;
     virtual void ApplyToolOptions(const QList<quint32> &oldDependencies, const QList<quint32> &newDependencies,
                                   const QDomElement &oldDomElement, const QDomElement &newDomElement);
-    virtual void AddToFile() override;
+    void AddToFile() override;
     void SaveOption(QSharedPointer<VGObject> &obj);
     virtual void SaveOptions(QDomElement &tag, QSharedPointer<VGObject> &obj);
     virtual auto MakeToolTip() const -> QString;

src/libs/vtools/tools/vtoolseamallowance.h

@@ -50,7 +50,7 @@ struct VToolSeamAllowanceInitData : VAbstractToolInitData
     QString drawName{}; // NOLINT(misc-non-private-member-variables-in-classes)
 };
 
-class VToolSeamAllowance : public VInteractiveTool, public QGraphicsPathItem
+class VToolSeamAllowance final : public VInteractiveTool, public QGraphicsPathItem
 {
     Q_OBJECT // NOLINT
 
@@ -161,8 +161,8 @@ protected:
     void SetVisualization() override {}
     void DeleteToolWithConfirm(bool ask = true) override;
     void ToolCreation(const Source &typeCreation) override;
-    void SetDialog() final;
+    void SetDialog() override;
-    void SaveDialogChange(const QString &undoText = QString()) final;
+    void SaveDialogChange(const QString &undoText = QString()) override;
 
 private slots:
     void ToggleInLayout(bool checked);