Default construct doesn't initialize constructor.

This commit is contained in:
Roman Telezhynskyi 2024-02-20 11:39:25 +02:00
parent 6df0ca7fca
commit f120519ede
28 changed files with 33 additions and 19 deletions

View File

@ -56,6 +56,7 @@ QT_WARNING_POP
//---------------------------------------------------------------------------------------------------------------------
VPCarrousel::VPCarrousel(const VPLayoutPtr &layout, QWidget *parent)
: QWidget(parent),
ui(std::make_unique<Ui::VPCarrousel>()),
m_layout(layout)
{
SCASSERT(not layout.isNull())

View File

@ -103,7 +103,7 @@ private slots:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(VPCarrousel) // NOLINT
std::unique_ptr<Ui::VPCarrousel> ui{};
std::unique_ptr<Ui::VPCarrousel> ui;
VPLayoutWeakPtr m_layout{};

View File

@ -39,7 +39,8 @@
//---------------------------------------------------------------------------------------------------------------------
PuzzlePreferencesConfigurationPage::PuzzlePreferencesConfigurationPage(QWidget *parent)
: QWidget(parent)
: QWidget(parent),
ui(std::make_unique<Ui::PuzzlePreferencesConfigurationPage>())
{
ui->setupUi(this);

View File

@ -55,7 +55,7 @@ private slots:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(PuzzlePreferencesConfigurationPage) // NOLINT
std::unique_ptr<Ui::PuzzlePreferencesConfigurationPage> ui{};
std::unique_ptr<Ui::PuzzlePreferencesConfigurationPage> ui;
bool m_langChanged{false};
QList<QStringList> m_transientShortcuts{};

View File

@ -31,7 +31,8 @@
//---------------------------------------------------------------------------------------------------------------------
PuzzlePreferencesLayoutPage::PuzzlePreferencesLayoutPage(QWidget *parent)
: QWidget(parent)
: QWidget(parent),
ui(std::make_unique<Ui::PuzzlePreferencesLayoutPage>())
{
ui->setupUi(this);

View File

@ -65,7 +65,7 @@ private slots:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(PuzzlePreferencesLayoutPage) // NOLINT
std::unique_ptr<Ui::PuzzlePreferencesLayoutPage> ui{};
std::unique_ptr<Ui::PuzzlePreferencesLayoutPage> ui;
Unit m_oldLayoutUnit{Unit::Mm};
bool m_settingsChanged{false};

View File

@ -31,7 +31,8 @@
//---------------------------------------------------------------------------------------------------------------------
PuzzlePreferencesPathPage::PuzzlePreferencesPathPage(QWidget *parent)
: QWidget(parent)
: QWidget(parent),
ui(std::make_unique<Ui::PuzzlePreferencesPathPage>())
{
ui->setupUi(this);

View File

@ -56,7 +56,7 @@ private slots:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(PuzzlePreferencesPathPage) // NOLINT
std::unique_ptr<Ui::PuzzlePreferencesPathPage> ui{};
std::unique_ptr<Ui::PuzzlePreferencesPathPage> ui;
void InitTable();
};

View File

@ -46,6 +46,7 @@ using namespace Qt::Literals::StringLiterals;
//---------------------------------------------------------------------------------------------------------------------
DialogPuzzlePreferences::DialogPuzzlePreferences(QWidget *parent)
: QDialog(parent),
ui(std::make_unique<Ui::DialogPuzzlePreferences>()),
m_configurationPage(new PuzzlePreferencesConfigurationPage),
m_layoutPage(new PuzzlePreferencesLayoutPage),
m_pathPage(new PuzzlePreferencesPathPage)

View File

@ -65,7 +65,7 @@ private slots:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(DialogPuzzlePreferences) // NOLINT
std::unique_ptr<Ui::DialogPuzzlePreferences> ui{};
std::unique_ptr<Ui::DialogPuzzlePreferences> ui;
bool m_isInitialized{false};
PuzzlePreferencesConfigurationPage *m_configurationPage;
PuzzlePreferencesLayoutPage *m_layoutPage;

View File

@ -59,6 +59,7 @@ QT_WARNING_POP
DialogSaveManualLayout::DialogSaveManualLayout(vsizetype count, bool consoleExport, const QString &fileName,
QWidget *parent)
: VAbstractLayoutDialog(parent),
ui(std::make_unique<Ui::DialogSaveManualLayout>()),
m_count(count),
m_consoleExport(consoleExport)
{

View File

@ -82,7 +82,7 @@ private slots:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(DialogSaveManualLayout) // NOLINT
std::unique_ptr<Ui::DialogSaveManualLayout> ui{};
std::unique_ptr<Ui::DialogSaveManualLayout> ui;
vsizetype m_count;
bool m_isInitialized{false};
bool m_scaleConnected{true};

View File

@ -53,6 +53,7 @@ using namespace Qt::Literals::StringLiterals;
//---------------------------------------------------------------------------------------------------------------------
VPDialogAbout::VPDialogAbout(QWidget *parent)
: QDialog(parent),
ui(std::make_unique<Ui::VPDialogAbout>()),
m_isInitialized(false)
{
ui->setupUi(this);

View File

@ -52,7 +52,7 @@ protected:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(VPDialogAbout) // NOLINT
std::unique_ptr<Ui::VPDialogAbout> ui{};
std::unique_ptr<Ui::VPDialogAbout> ui;
bool m_isInitialized;
static void FontPointSize(QWidget *w, int pointSize);

View File

@ -323,6 +323,7 @@ struct VPExportData
//---------------------------------------------------------------------------------------------------------------------
VPMainWindow::VPMainWindow(const VPCommandLinePtr &cmd, QWidget *parent)
: VAbstractMainWindow(parent),
ui(std::make_unique<Ui::VPMainWindow>()),
m_cmd(cmd),
m_undoStack(new QUndoStack(this)),
m_layout{VPLayout::CreateLayout(m_undoStack)},

View File

@ -303,7 +303,7 @@ private slots:
private:
Q_DISABLE_COPY_MOVE(VPMainWindow) // NOLINT
std::unique_ptr<Ui::VPMainWindow> ui{};
std::unique_ptr<Ui::VPMainWindow> ui;
std::unique_ptr<VPCarrousel> m_carrousel{nullptr};
VPMainGraphicsView *m_graphicsView{nullptr};

View File

@ -44,6 +44,7 @@
//---------------------------------------------------------------------------------------------------------------------
TapePreferencesConfigurationPage::TapePreferencesConfigurationPage(QWidget *parent)
: QWidget(parent),
ui(std::make_unique<Ui::TapePreferencesConfigurationPage>()),
m_langChanged(false),
m_systemChanged(false)
{

View File

@ -58,7 +58,7 @@ private slots:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(TapePreferencesConfigurationPage) // NOLINT
std::unique_ptr<Ui::TapePreferencesConfigurationPage> ui{};
std::unique_ptr<Ui::TapePreferencesConfigurationPage> ui;
bool m_langChanged;
bool m_systemChanged;
QList<QStringList> m_transientShortcuts{};

View File

@ -32,7 +32,8 @@
//---------------------------------------------------------------------------------------------------------------------
TapePreferencesPathPage::TapePreferencesPathPage(QWidget *parent)
: QWidget(parent)
: QWidget(parent),
ui(std::make_unique<Ui::TapePreferencesPathPage>())
{
ui->setupUi(this);

View File

@ -56,7 +56,7 @@ private slots:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(TapePreferencesPathPage) // NOLINT
std::unique_ptr<Ui::TapePreferencesPathPage> ui{};
std::unique_ptr<Ui::TapePreferencesPathPage> ui;
void InitTable();
};

View File

@ -47,6 +47,7 @@
//---------------------------------------------------------------------------------------------------------------------
DialogAboutTape::DialogAboutTape(QWidget *parent)
: QDialog(parent),
ui(std::make_unique<Ui::DialogAboutTape>()),
m_isInitialized(false)
{
ui->setupUi(this);

View File

@ -52,7 +52,7 @@ protected:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(DialogAboutTape) // NOLINT
std::unique_ptr<Ui::DialogAboutTape> ui{};
std::unique_ptr<Ui::DialogAboutTape> ui;
bool m_isInitialized;
static void FontPointSize(QWidget *w, int pointSize);

View File

@ -31,7 +31,8 @@
//---------------------------------------------------------------------------------------------------------------------
DialogDimensionCustomNames::DialogDimensionCustomNames(
const QMap<MeasurementDimension, MeasurementDimension_p> &dimensions, QWidget *parent)
: QDialog(parent)
: QDialog(parent),
ui(std::make_unique<Ui::DialogDimensionCustomNames>())
{
ui->setupUi(this);

View File

@ -52,7 +52,7 @@ public:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(DialogDimensionCustomNames) // NOLINT
std::unique_ptr<Ui::DialogDimensionCustomNames> ui{};
std::unique_ptr<Ui::DialogDimensionCustomNames> ui;
void InitTable(const QMap<MeasurementDimension, MeasurementDimension_p> &dimensions);
};

View File

@ -32,6 +32,7 @@
DialogDimensionLabels::DialogDimensionLabels(const QMap<MeasurementDimension, MeasurementDimension_p> &dimensions,
bool fullCircumference, QWidget *parent)
: QDialog(parent),
ui(std::make_unique<Ui::DialogDimensionLabels>()),
m_dimensions(dimensions),
m_fullCircumference(fullCircumference)
{

View File

@ -62,7 +62,7 @@ private slots:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(DialogDimensionLabels) // NOLINT
std::unique_ptr<Ui::DialogDimensionLabels> ui{};
std::unique_ptr<Ui::DialogDimensionLabels> ui;
QMap<MeasurementDimension, MeasurementDimension_p> m_dimensions;
QMap<MeasurementDimension, DimesionLabels> m_labels{};

View File

@ -51,6 +51,7 @@ using namespace Qt::Literals::StringLiterals;
//---------------------------------------------------------------------------------------------------------------------
DialogKnownMeasurementsCSVColumns::DialogKnownMeasurementsCSVColumns(QString filename, QWidget *parent)
: QDialog(parent),
ui(std::make_unique<Ui::DialogKnownMeasurementsCSVColumns>()),
m_fileName{std::move(filename)}
{
ui->setupUi(this);

View File

@ -80,7 +80,7 @@ private slots:
private:
// cppcheck-suppress unknownMacro
Q_DISABLE_COPY_MOVE(DialogKnownMeasurementsCSVColumns) // NOLINT
std::unique_ptr<Ui::DialogKnownMeasurementsCSVColumns> ui{};
std::unique_ptr<Ui::DialogKnownMeasurementsCSVColumns> ui;
bool m_isInitialized{false};
QString m_fileName;
bool m_withHeader{false};