From ca66c8ebe28fcdfc0cae40de48b0bddff9553353 Mon Sep 17 00:00:00 2001 From: Roman Telezhynskyi Date: Wed, 2 Aug 2017 11:34:44 +0300 Subject: [PATCH] Improve performance. Calling method RefreshDataInFile() slows down parsing. --HG-- branch : develop --- src/libs/ifc/xml/vdomdocument.cpp | 4 ++-- .../operation/vabstractoperation.cpp | 15 -------------- .../drawTools/operation/vabstractoperation.h | 1 - .../tooldoublepoint/vtooldoublepoint.cpp | 15 -------------- .../tooldoublepoint/vtooldoublepoint.h | 1 - src/libs/vtools/tools/drawTools/vdrawtool.cpp | 18 ----------------- src/libs/vtools/tools/drawTools/vdrawtool.h | 1 - src/libs/vtools/tools/drawTools/vtoolline.cpp | 18 ----------------- src/libs/vtools/tools/drawTools/vtoolline.h | 1 - .../vtools/tools/nodeDetails/vnodearc.cpp | 17 ---------------- src/libs/vtools/tools/nodeDetails/vnodearc.h | 1 - .../tools/nodeDetails/vnodeellipticalarc.cpp | 14 ------------- .../tools/nodeDetails/vnodeellipticalarc.h | 1 - .../vtools/tools/nodeDetails/vnodepoint.cpp | 20 ------------------- .../vtools/tools/nodeDetails/vnodepoint.h | 1 - .../vtools/tools/nodeDetails/vnodespline.cpp | 17 ---------------- .../vtools/tools/nodeDetails/vnodespline.h | 1 - .../tools/nodeDetails/vnodesplinepath.cpp | 17 ---------------- .../tools/nodeDetails/vnodesplinepath.h | 1 - .../tools/nodeDetails/vtoolpiecepath.cpp | 13 ------------ .../vtools/tools/nodeDetails/vtoolpiecepath.h | 1 - .../vtools/tools/nodeDetails/vtoolpin.cpp | 6 ------ src/libs/vtools/tools/nodeDetails/vtoolpin.h | 1 - src/libs/vtools/tools/vabstracttool.cpp | 6 ++++++ src/libs/vtools/tools/vabstracttool.h | 2 +- src/libs/vtools/tools/vtooluniondetails.cpp | 9 --------- src/libs/vtools/tools/vtooluniondetails.h | 1 - 27 files changed, 9 insertions(+), 194 deletions(-) diff --git a/src/libs/ifc/xml/vdomdocument.cpp b/src/libs/ifc/xml/vdomdocument.cpp index 2b2d5b9bb..9d87154e6 100644 --- a/src/libs/ifc/xml/vdomdocument.cpp +++ b/src/libs/ifc/xml/vdomdocument.cpp @@ -198,7 +198,7 @@ QDomElement VDomDocument::elementById(const QString& id) { if (map.contains(id)) { - QDomElement e = map[id]; + const QDomElement e = map[id]; if (e.parentNode().nodeType() != QDomNode::BaseNode) { return e; @@ -241,7 +241,7 @@ bool VDomDocument::find(const QDomElement &node, const QString& id) for (qint32 i=0; ifind(n.toElement(), id)) diff --git a/src/libs/vtools/tools/drawTools/operation/vabstractoperation.cpp b/src/libs/vtools/tools/drawTools/operation/vabstractoperation.cpp index 7b103e632..91035aea5 100644 --- a/src/libs/vtools/tools/drawTools/operation/vabstractoperation.cpp +++ b/src/libs/vtools/tools/drawTools/operation/vabstractoperation.cpp @@ -425,21 +425,6 @@ void VAbstractOperation::AddToFile() AddToCalculation(domElement); } -//--------------------------------------------------------------------------------------------------------------------- -void VAbstractOperation::RefreshDataInFile() -{ - QDomElement domElement = doc->elementById(id); - if (domElement.isElement()) - { - QSharedPointer obj = VContainer::GetFakeGObject(id); - SaveOptions(domElement, obj); - } - else - { - qCDebug(vTool, "Can't find tool with id = %u", id); - } -} - //--------------------------------------------------------------------------------------------------------------------- void VAbstractOperation::UpdateNamePosition(quint32 id) { diff --git a/src/libs/vtools/tools/drawTools/operation/vabstractoperation.h b/src/libs/vtools/tools/drawTools/operation/vabstractoperation.h index a74879e68..ce0111ee7 100644 --- a/src/libs/vtools/tools/drawTools/operation/vabstractoperation.h +++ b/src/libs/vtools/tools/drawTools/operation/vabstractoperation.h @@ -118,7 +118,6 @@ protected: QGraphicsItem *parent = nullptr); virtual void AddToFile() Q_DECL_OVERRIDE; - virtual void RefreshDataInFile() Q_DECL_OVERRIDE; void UpdateNamePosition(quint32 id); void SaveSourceDestination(QDomElement &tag); diff --git a/src/libs/vtools/tools/drawTools/toolpoint/tooldoublepoint/vtooldoublepoint.cpp b/src/libs/vtools/tools/drawTools/toolpoint/tooldoublepoint/vtooldoublepoint.cpp index 95c49549c..23821aa24 100644 --- a/src/libs/vtools/tools/drawTools/toolpoint/tooldoublepoint/vtooldoublepoint.cpp +++ b/src/libs/vtools/tools/drawTools/toolpoint/tooldoublepoint/vtooldoublepoint.cpp @@ -363,18 +363,3 @@ void VToolDoublePoint::AddToFile() SaveOptions(domElement, obj); AddToCalculation(domElement); } - -//--------------------------------------------------------------------------------------------------------------------- -void VToolDoublePoint::RefreshDataInFile() -{ - QDomElement domElement = doc->elementById(id); - if (domElement.isElement()) - { - QSharedPointer obj = VContainer::GetFakeGObject(id); - SaveOptions(domElement, obj); - } - else - { - qCDebug(vTool, "Can't find tool with id = %u", id); - } -} diff --git a/src/libs/vtools/tools/drawTools/toolpoint/tooldoublepoint/vtooldoublepoint.h b/src/libs/vtools/tools/drawTools/toolpoint/tooldoublepoint/vtooldoublepoint.h index 0531d531c..b069959fd 100644 --- a/src/libs/vtools/tools/drawTools/toolpoint/tooldoublepoint/vtooldoublepoint.h +++ b/src/libs/vtools/tools/drawTools/toolpoint/tooldoublepoint/vtooldoublepoint.h @@ -93,7 +93,6 @@ protected: virtual void contextMenuEvent ( QGraphicsSceneContextMenuEvent * event ) Q_DECL_OVERRIDE; virtual void SaveOptions(QDomElement &tag, QSharedPointer &obj) Q_DECL_OVERRIDE; virtual void AddToFile() Q_DECL_OVERRIDE; - virtual void RefreshDataInFile() Q_DECL_OVERRIDE; private: Q_DISABLE_COPY(VToolDoublePoint) diff --git a/src/libs/vtools/tools/drawTools/vdrawtool.cpp b/src/libs/vtools/tools/drawTools/vdrawtool.cpp index 6235634f9..6e0125aa8 100644 --- a/src/libs/vtools/tools/drawTools/vdrawtool.cpp +++ b/src/libs/vtools/tools/drawTools/vdrawtool.cpp @@ -134,24 +134,6 @@ void VDrawTool::AddToFile() AddToCalculation(domElement); } -//--------------------------------------------------------------------------------------------------------------------- -/** - * @brief RefreshDataInFile refresh attributes in file. If attributes don't exist create them. - */ -void VDrawTool::RefreshDataInFile() -{ - QDomElement domElement = doc->elementById(id); - if (domElement.isElement()) - { - QSharedPointer obj = VAbstractTool::data.GetGObject(id); - SaveOptions(domElement, obj); - } - else - { - qCDebug(vTool, "Can't find tool with id = %u", id); - } -} - //--------------------------------------------------------------------------------------------------------------------- void VDrawTool::SaveOption(QSharedPointer &obj) { diff --git a/src/libs/vtools/tools/drawTools/vdrawtool.h b/src/libs/vtools/tools/drawTools/vdrawtool.h index c4a179bd3..813d6c9eb 100644 --- a/src/libs/vtools/tools/drawTools/vdrawtool.h +++ b/src/libs/vtools/tools/drawTools/vdrawtool.h @@ -93,7 +93,6 @@ protected: virtual void SaveDialog(QDomElement &domElement)=0; virtual void SaveDialogChange() Q_DECL_FINAL; virtual void AddToFile() Q_DECL_OVERRIDE; - virtual void RefreshDataInFile() Q_DECL_OVERRIDE; void SaveOption(QSharedPointer &obj); virtual void SaveOptions(QDomElement &tag, QSharedPointer &obj); diff --git a/src/libs/vtools/tools/drawTools/vtoolline.cpp b/src/libs/vtools/tools/drawTools/vtoolline.cpp index f51f388c0..b54ae6df2 100644 --- a/src/libs/vtools/tools/drawTools/vtoolline.cpp +++ b/src/libs/vtools/tools/drawTools/vtoolline.cpp @@ -287,24 +287,6 @@ void VToolLine::AddToFile() AddToCalculation(domElement); } -//--------------------------------------------------------------------------------------------------------------------- -/** - * @brief RefreshDataInFile refresh attributes in file. If attributes don't exist create them. - */ -void VToolLine::RefreshDataInFile() -{ - QDomElement domElement = doc->elementById(id); - if (domElement.isElement()) - { - QSharedPointer obj = QSharedPointer (); - SaveOptions(domElement, obj); - } - else - { - qDebug()<<"Can't find tool with id ="<< id << Q_FUNC_INFO; - } -} - //--------------------------------------------------------------------------------------------------------------------- /** * @brief hoverEnterEvent handle hover enter events. diff --git a/src/libs/vtools/tools/drawTools/vtoolline.h b/src/libs/vtools/tools/drawTools/vtoolline.h index 71d5063a5..de2ab9403 100644 --- a/src/libs/vtools/tools/drawTools/vtoolline.h +++ b/src/libs/vtools/tools/drawTools/vtoolline.h @@ -92,7 +92,6 @@ public slots: protected: virtual void contextMenuEvent ( QGraphicsSceneContextMenuEvent * event ) Q_DECL_OVERRIDE; virtual void AddToFile() Q_DECL_OVERRIDE; - virtual void RefreshDataInFile() Q_DECL_OVERRIDE; virtual void hoverEnterEvent ( QGraphicsSceneHoverEvent * event ) Q_DECL_OVERRIDE; virtual void hoverLeaveEvent ( QGraphicsSceneHoverEvent * event ) Q_DECL_OVERRIDE; virtual void RemoveReferens() Q_DECL_OVERRIDE; diff --git a/src/libs/vtools/tools/nodeDetails/vnodearc.cpp b/src/libs/vtools/tools/nodeDetails/vnodearc.cpp index 14b7e670c..4e5398cac 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodearc.cpp +++ b/src/libs/vtools/tools/nodeDetails/vnodearc.cpp @@ -136,20 +136,3 @@ void VNodeArc::AddToFile() AddToModeling(domElement); } - -//--------------------------------------------------------------------------------------------------------------------- -/** - * @brief RefreshDataInFile refresh attributes in file. If attributes don't exist create them. - */ -void VNodeArc::RefreshDataInFile() -{ - QDomElement domElement = doc->elementById(id); - if (domElement.isElement()) - { - doc->SetAttribute(domElement, AttrIdObject, idNode); - if (idTool != NULL_ID) - { - doc->SetAttribute(domElement, AttrIdTool, idTool); - } - } -} diff --git a/src/libs/vtools/tools/nodeDetails/vnodearc.h b/src/libs/vtools/tools/nodeDetails/vnodearc.h index e9d81714f..151f224f8 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodearc.h +++ b/src/libs/vtools/tools/nodeDetails/vnodearc.h @@ -58,7 +58,6 @@ public slots: virtual void AllowSelecting(bool enabled) Q_DECL_OVERRIDE; protected: virtual void AddToFile() Q_DECL_OVERRIDE; - virtual void RefreshDataInFile() Q_DECL_OVERRIDE; virtual void ShowNode() Q_DECL_OVERRIDE {} virtual void HideNode() Q_DECL_OVERRIDE {} private: diff --git a/src/libs/vtools/tools/nodeDetails/vnodeellipticalarc.cpp b/src/libs/vtools/tools/nodeDetails/vnodeellipticalarc.cpp index 13a746854..22044d11e 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodeellipticalarc.cpp +++ b/src/libs/vtools/tools/nodeDetails/vnodeellipticalarc.cpp @@ -107,20 +107,6 @@ void VNodeEllipticalArc::AddToFile() AddToModeling(domElement); } -//--------------------------------------------------------------------------------------------------------------------- -void VNodeEllipticalArc::RefreshDataInFile() -{ - QDomElement domElement = doc->elementById(id); - if (domElement.isElement()) - { - doc->SetAttribute(domElement, AttrIdObject, idNode); - if (idTool != NULL_ID) - { - doc->SetAttribute(domElement, AttrIdTool, idTool); - } - } -} - //--------------------------------------------------------------------------------------------------------------------- VNodeEllipticalArc::VNodeEllipticalArc(VAbstractPattern *doc, VContainer *data, quint32 id, quint32 idArc, const Source &typeCreation, const QString &drawName, const quint32 &idTool, diff --git a/src/libs/vtools/tools/nodeDetails/vnodeellipticalarc.h b/src/libs/vtools/tools/nodeDetails/vnodeellipticalarc.h index eed1af012..f7933e922 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodeellipticalarc.h +++ b/src/libs/vtools/tools/nodeDetails/vnodeellipticalarc.h @@ -56,7 +56,6 @@ public slots: virtual void AllowSelecting(bool enabled) Q_DECL_OVERRIDE; protected: virtual void AddToFile() Q_DECL_OVERRIDE; - virtual void RefreshDataInFile() Q_DECL_OVERRIDE; virtual void ShowNode() Q_DECL_OVERRIDE {} virtual void HideNode() Q_DECL_OVERRIDE {} private: diff --git a/src/libs/vtools/tools/nodeDetails/vnodepoint.cpp b/src/libs/vtools/tools/nodeDetails/vnodepoint.cpp index 6aac94f90..b5c6172f4 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodepoint.cpp +++ b/src/libs/vtools/tools/nodeDetails/vnodepoint.cpp @@ -177,26 +177,6 @@ void VNodePoint::AddToFile() AddToModeling(domElement); } -//--------------------------------------------------------------------------------------------------------------------- -/** - * @brief RefreshDataInFile refresh attributes in file. If attributes don't exist create them. - */ -void VNodePoint::RefreshDataInFile() -{ - const QSharedPointer point = VAbstractTool::data.GeometricObject(id); - QDomElement domElement = doc->elementById(id); - if (domElement.isElement()) - { - doc->SetAttribute(domElement, AttrIdObject, idNode); - doc->SetAttribute(domElement, AttrMx, qApp->fromPixel(point->mx())); - doc->SetAttribute(domElement, AttrMy, qApp->fromPixel(point->my())); - if (idTool != NULL_ID) - { - doc->SetAttribute(domElement, AttrIdTool, idTool); - } - } -} - //--------------------------------------------------------------------------------------------------------------------- void VNodePoint::mousePressEvent(QGraphicsSceneMouseEvent *event) { diff --git a/src/libs/vtools/tools/nodeDetails/vnodepoint.h b/src/libs/vtools/tools/nodeDetails/vnodepoint.h index cae88ffbd..4921a8083 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodepoint.h +++ b/src/libs/vtools/tools/nodeDetails/vnodepoint.h @@ -77,7 +77,6 @@ public slots: void AllowLabelSelecting(bool enabled); protected: virtual void AddToFile() Q_DECL_OVERRIDE; - virtual void RefreshDataInFile() Q_DECL_OVERRIDE; virtual void mousePressEvent(QGraphicsSceneMouseEvent *event) Q_DECL_OVERRIDE; virtual void mouseReleaseEvent ( QGraphicsSceneMouseEvent * event ) Q_DECL_OVERRIDE; virtual void UpdateNamePosition(qreal mx, qreal my); diff --git a/src/libs/vtools/tools/nodeDetails/vnodespline.cpp b/src/libs/vtools/tools/nodeDetails/vnodespline.cpp index dfad04c80..dc7a8d2b0 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodespline.cpp +++ b/src/libs/vtools/tools/nodeDetails/vnodespline.cpp @@ -140,20 +140,3 @@ void VNodeSpline::AddToFile() AddToModeling(domElement); } - -//--------------------------------------------------------------------------------------------------------------------- -/** - * @brief RefreshDataInFile refresh attributes in file. If attributes don't exist create them. - */ -void VNodeSpline::RefreshDataInFile() -{ - QDomElement domElement = doc->elementById(id); - if (domElement.isElement()) - { - doc->SetAttribute(domElement, AttrIdObject, QString().setNum(idNode)); - if (idTool != NULL_ID) - { - doc->SetAttribute(domElement, AttrIdTool, idTool); - } - } -} diff --git a/src/libs/vtools/tools/nodeDetails/vnodespline.h b/src/libs/vtools/tools/nodeDetails/vnodespline.h index 092c77522..51b11ec5f 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodespline.h +++ b/src/libs/vtools/tools/nodeDetails/vnodespline.h @@ -60,7 +60,6 @@ public slots: virtual void AllowSelecting(bool enabled) Q_DECL_OVERRIDE; protected: virtual void AddToFile () Q_DECL_OVERRIDE; - virtual void RefreshDataInFile() Q_DECL_OVERRIDE; virtual void ShowNode() Q_DECL_OVERRIDE {} virtual void HideNode() Q_DECL_OVERRIDE {} private: diff --git a/src/libs/vtools/tools/nodeDetails/vnodesplinepath.cpp b/src/libs/vtools/tools/nodeDetails/vnodesplinepath.cpp index 0bb53f899..153312218 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodesplinepath.cpp +++ b/src/libs/vtools/tools/nodeDetails/vnodesplinepath.cpp @@ -138,20 +138,3 @@ void VNodeSplinePath::AddToFile() AddToModeling(domElement); } - -//--------------------------------------------------------------------------------------------------------------------- -/** - * @brief RefreshDataInFile refresh attributes in file. If attributes don't exist create them. - */ -void VNodeSplinePath::RefreshDataInFile() -{ - QDomElement domElement = doc->elementById(id); - if (domElement.isElement()) - { - doc->SetAttribute(domElement, AttrIdObject, QString().setNum(idNode)); - if (idTool != 0) - { - doc->SetAttribute(domElement, AttrIdTool, idTool); - } - } -} diff --git a/src/libs/vtools/tools/nodeDetails/vnodesplinepath.h b/src/libs/vtools/tools/nodeDetails/vnodesplinepath.h index fe5d15479..50b69f81a 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodesplinepath.h +++ b/src/libs/vtools/tools/nodeDetails/vnodesplinepath.h @@ -59,7 +59,6 @@ public slots: virtual void AllowSelecting(bool enabled) Q_DECL_OVERRIDE; protected: virtual void AddToFile() Q_DECL_OVERRIDE; - virtual void RefreshDataInFile() Q_DECL_OVERRIDE; virtual void ShowNode() Q_DECL_OVERRIDE {} virtual void HideNode() Q_DECL_OVERRIDE {} private: diff --git a/src/libs/vtools/tools/nodeDetails/vtoolpiecepath.cpp b/src/libs/vtools/tools/nodeDetails/vtoolpiecepath.cpp index 69c378016..6e088f964 100644 --- a/src/libs/vtools/tools/nodeDetails/vtoolpiecepath.cpp +++ b/src/libs/vtools/tools/nodeDetails/vtoolpiecepath.cpp @@ -252,19 +252,6 @@ void VToolPiecePath::AddToFile() } } -//--------------------------------------------------------------------------------------------------------------------- -void VToolPiecePath::RefreshDataInFile() -{ - QDomElement domElement = doc->elementById(id); - if (domElement.isElement()) - { - if (idTool != NULL_ID) - { - doc->SetAttribute(domElement, AttrIdTool, idTool); - } - } -} - //--------------------------------------------------------------------------------------------------------------------- void VToolPiecePath::ShowNode() { diff --git a/src/libs/vtools/tools/nodeDetails/vtoolpiecepath.h b/src/libs/vtools/tools/nodeDetails/vtoolpiecepath.h index c95d8f318..4aa231702 100644 --- a/src/libs/vtools/tools/nodeDetails/vtoolpiecepath.h +++ b/src/libs/vtools/tools/nodeDetails/vtoolpiecepath.h @@ -63,7 +63,6 @@ public slots: virtual void AllowSelecting(bool enabled) Q_DECL_OVERRIDE; protected: virtual void AddToFile() Q_DECL_OVERRIDE; - virtual void RefreshDataInFile() Q_DECL_OVERRIDE; virtual void ShowNode() Q_DECL_OVERRIDE; virtual void HideNode() Q_DECL_OVERRIDE; virtual void ToolCreation(const Source &typeCreation) Q_DECL_OVERRIDE; diff --git a/src/libs/vtools/tools/nodeDetails/vtoolpin.cpp b/src/libs/vtools/tools/nodeDetails/vtoolpin.cpp index 48983635b..9d54ea4e0 100644 --- a/src/libs/vtools/tools/nodeDetails/vtoolpin.cpp +++ b/src/libs/vtools/tools/nodeDetails/vtoolpin.cpp @@ -152,12 +152,6 @@ void VToolPin::AddToFile() } } -//--------------------------------------------------------------------------------------------------------------------- -void VToolPin::RefreshDataInFile() -{ - // do nothing -} - //--------------------------------------------------------------------------------------------------------------------- VToolPin::VToolPin(VAbstractPattern *doc, VContainer *data, quint32 id, quint32 pointId, quint32 pieceId, const Source &typeCreation, const QString &drawName, const quint32 &idTool, QObject *qoParent) diff --git a/src/libs/vtools/tools/nodeDetails/vtoolpin.h b/src/libs/vtools/tools/nodeDetails/vtoolpin.h index 5d53a2252..801f5e9a3 100644 --- a/src/libs/vtools/tools/nodeDetails/vtoolpin.h +++ b/src/libs/vtools/tools/nodeDetails/vtoolpin.h @@ -52,7 +52,6 @@ public slots: virtual void AllowSelecting(bool enabled) Q_DECL_OVERRIDE; protected: virtual void AddToFile() Q_DECL_OVERRIDE; - virtual void RefreshDataInFile() Q_DECL_OVERRIDE; virtual void ShowNode() Q_DECL_OVERRIDE {} virtual void HideNode() Q_DECL_OVERRIDE {} private: diff --git a/src/libs/vtools/tools/vabstracttool.cpp b/src/libs/vtools/tools/vabstracttool.cpp index d26219066..6219647dd 100644 --- a/src/libs/vtools/tools/vabstracttool.cpp +++ b/src/libs/vtools/tools/vabstracttool.cpp @@ -403,6 +403,12 @@ void VAbstractTool::ToolSelectionType(const SelectionType &type) selectionType = type; } +//--------------------------------------------------------------------------------------------------------------------- +void VAbstractTool::RefreshDataInFile() +{ + // do nothing +} + //--------------------------------------------------------------------------------------------------------------------- void VAbstractTool::ToolCreation(const Source &typeCreation) { diff --git a/src/libs/vtools/tools/vabstracttool.h b/src/libs/vtools/tools/vabstracttool.h index 750e6c92c..f72896166 100644 --- a/src/libs/vtools/tools/vabstracttool.h +++ b/src/libs/vtools/tools/vabstracttool.h @@ -121,7 +121,7 @@ protected: /** * @brief RefreshDataInFile refresh attributes in file. If attributes don't exist create them. */ - virtual void RefreshDataInFile()=0; + virtual void RefreshDataInFile(); /** * @brief RemoveReferens decrement value of reference. */ diff --git a/src/libs/vtools/tools/vtooluniondetails.cpp b/src/libs/vtools/tools/vtooluniondetails.cpp index cb5761112..7e6d516e6 100644 --- a/src/libs/vtools/tools/vtooluniondetails.cpp +++ b/src/libs/vtools/tools/vtooluniondetails.cpp @@ -1512,15 +1512,6 @@ void VToolUnionDetails::AddToFile() AddToModeling(domElement); } -//--------------------------------------------------------------------------------------------------------------------- -/** - * @brief RefreshDataInFile refresh attributes in file. If attributes don't exist create them. - */ -void VToolUnionDetails::RefreshDataInFile() -{ - // do nothing -} - //--------------------------------------------------------------------------------------------------------------------- /** * @brief AddDetail add detail to xml file. diff --git a/src/libs/vtools/tools/vtooluniondetails.h b/src/libs/vtools/tools/vtooluniondetails.h index 27e61de9f..be87eba7b 100644 --- a/src/libs/vtools/tools/vtooluniondetails.h +++ b/src/libs/vtools/tools/vtooluniondetails.h @@ -111,7 +111,6 @@ public slots: virtual void AllowSelecting(bool) Q_DECL_OVERRIDE {} protected: virtual void AddToFile() Q_DECL_OVERRIDE; - virtual void RefreshDataInFile() Q_DECL_OVERRIDE; virtual void SetVisualization() Q_DECL_OVERRIDE {} private: Q_DISABLE_COPY(VToolUnionDetails)