Refactoring. Minor changes.

--HG--
branch : develop

src/libs/ifc/xml/vabstractpattern.cpp

@@ -1558,13 +1558,12 @@ void VAbstractPattern::InsertTag(const QStringList &tags, const QDomElement &ele
     for (int i = tags.indexOf(element.tagName())-1; i >= 0; --i)
     {
         const QDomNodeList list = elementsByTagName(tags.at(i));
-        if (list.isEmpty())
+        if (not list.isEmpty())
         {
-            continue;
-        }
             pattern.insertAfter(element, list.at(0));
             break;
         }
+    }
     SetVersion();
 }
 

src/libs/ifc/xml/vpatternconverter.cpp

@@ -212,6 +212,7 @@ QString VPatternConverter::XSDSchema(int ver) const
             InvalidVersion(ver);
             break;
     }
+    return QString();//unreachable code
 }
 
 //---------------------------------------------------------------------------------------------------------------------

src/libs/ifc/xml/vtoolrecord.cpp

@@ -62,6 +62,11 @@ bool VToolRecord::operator==(const VToolRecord &record) const
 //---------------------------------------------------------------------------------------------------------------------
 VToolRecord &VToolRecord::operator=(const VToolRecord &record)
 {
+    if ( &record == this )
+    {
+        return *this;
+    }
+
     this->id = record.getId();
     this->typeTool = record.getTypeTool();
     this->nameDraw = record.getNameDraw();

src/libs/ifc/xml/vvitconverter.cpp

@@ -92,6 +92,7 @@ QString VVITConverter::XSDSchema(int ver) const
             InvalidVersion(ver);
             break;
     }
+    return QString();//unreachable code
 }
 
 //---------------------------------------------------------------------------------------------------------------------

src/libs/ifc/xml/vvstconverter.cpp

@@ -94,6 +94,7 @@ QString VVSTConverter::XSDSchema(int ver) const
             InvalidVersion(ver);
             break;
     }
+    return QString();//unreachable code
 }
 
 //---------------------------------------------------------------------------------------------------------------------

src/libs/vtools/dialogs/tools/piece/dialogseamallowance.cpp

@@ -46,7 +46,7 @@
 #include <QTimer>
 #include <QtNumeric>
 
-enum TabOrder {Paths=0, Labels=1, Grainline=2, Pins=3, Count};
+enum TabOrder {Paths=0, Labels=1, Grainline=2, Pins=3, Count=4};
 
 namespace
 {