From 6f56b46d262fdb198840716cf39d8a8859a29faf Mon Sep 17 00:00:00 2001 From: Roman Telezhynskyi Date: Tue, 3 May 2016 19:50:37 +0300 Subject: [PATCH] Fixed Clang warnings. --HG-- branch : develop --- common.pri | 2 ++ src/app/tape/mapplication.h | 2 +- src/app/valentina/core/vapplication.h | 4 ++-- src/app/valentina/core/vformulaproperty.h | 2 +- src/app/valentina/core/vformulapropertyeditor.h | 2 +- src/app/valentina/xml/vpattern.h | 2 +- src/libs/ifc/exception/vexception.h | 2 +- src/libs/ifc/xml/vpatternconverter.h | 2 +- src/libs/ifc/xml/vvitconverter.h | 2 +- src/libs/ifc/xml/vvstconverter.h | 2 +- src/libs/vdxf/dxflib/dl_entities.h | 13 +++++++++++++ src/libs/vdxf/dxflib/dl_extrusion.h | 4 +--- src/libs/vdxf/dxflib/dl_writer_ascii.cpp | 2 +- src/libs/vformat/vmeasurements.h | 2 +- src/libs/vgeometry/varc.h | 4 ++-- src/libs/vgeometry/vellipticalarc.h | 4 ++-- src/libs/vgeometry/vspline.cpp | 2 -- src/libs/vlayout/vlayoutgenerator.cpp | 4 ++-- .../plugins/Vector3d/vvector3dproperty.h | 2 +- .../plugins/vcolorpropertyeditor.h | 2 +- .../vpropertyexplorer/plugins/vfilepropertyeditor.h | 10 +++++----- .../plugins/vshortcutpropertyeditor.h | 2 +- src/libs/vpropertyexplorer/vpropertyformview.h | 2 +- src/libs/vpropertyexplorer/vpropertymodel.h | 2 +- src/libs/vtools/dialogs/tools/dialogcubicbezier.cpp | 4 ++-- .../vtools/dialogs/tools/dialogcubicbezierpath.cpp | 4 ++-- src/libs/vtools/dialogs/tools/dialogspline.cpp | 4 ++-- src/libs/vtools/dialogs/tools/dialogsplinepath.cpp | 4 ++-- src/libs/vtools/dialogs/tools/dialogtool.h | 2 +- src/libs/vtools/dialogs/tools/dialogtriangle.h | 2 +- src/libs/vtools/dialogs/tools/dialoguniondetails.h | 2 +- .../tools/drawTools/toolcurve/vtoolsplinepath.cpp | 2 +- .../toolpoint/toolsinglepoint/vtoolbasepoint.h | 2 +- src/libs/vtools/tools/nodeDetails/vabstractnode.h | 2 +- src/libs/vtools/tools/nodeDetails/vnodearc.cpp | 2 -- src/libs/vtools/tools/nodeDetails/vnodepoint.cpp | 1 - src/libs/vtools/tools/nodeDetails/vnodespline.cpp | 1 - .../vtools/tools/nodeDetails/vnodesplinepath.cpp | 2 -- src/libs/vtools/tools/vtooluniondetails.cpp | 2 -- src/libs/vwidgets/vgraphicssimpletextitem.h | 2 +- 40 files changed, 59 insertions(+), 56 deletions(-) diff --git a/common.pri b/common.pri index 7ae533b01..43c450566 100644 --- a/common.pri +++ b/common.pri @@ -301,6 +301,7 @@ CLANG_DEBUG_CXXFLAGS += \ -Wbad-array-new-length \ -Wbad-function-cast \ -Wbind-to-temporary-copy \ + -Wno-c++98-compat-bind-to-temporary-copy \ -Wbitfield-constant-conversion \ -Wbitwise-op-parentheses \ -Wbool-conversion \ @@ -446,6 +447,7 @@ CLANG_DEBUG_CXXFLAGS += \ -Wliteral-conversion \ -Wliteral-range \ -Wlocal-type-template-args \ + -Wno-c++98-compat-local-type-template-args \ -Wlogical-not-parentheses \ -Wlogical-op-parentheses \ -Wlong-long \ diff --git a/src/app/tape/mapplication.h b/src/app/tape/mapplication.h index 6efda298b..17cd27d84 100644 --- a/src/app/tape/mapplication.h +++ b/src/app/tape/mapplication.h @@ -57,7 +57,7 @@ public: virtual bool notify(QObject * receiver, QEvent * event) Q_DECL_OVERRIDE; bool IsTestMode() const; - virtual bool IsAppInGUIMode() const; + virtual bool IsAppInGUIMode() const Q_DECL_OVERRIDE; TMainWindow *MainWindow(); QList MainWindows(); diff --git a/src/app/valentina/core/vapplication.h b/src/app/valentina/core/vapplication.h index 5edc5fd8f..ccfad04fd 100644 --- a/src/app/valentina/core/vapplication.h +++ b/src/app/valentina/core/vapplication.h @@ -71,14 +71,14 @@ public: void StartLogging(); QTextStream *LogFile(); - virtual const VTranslateVars *TrVars(); + virtual const VTranslateVars *TrVars() Q_DECL_OVERRIDE; #if defined(Q_OS_WIN) && defined(Q_CC_GNU) static void DrMingw(); void CollectReports() const; #endif // defined(Q_OS_WIN) && defined(Q_CC_GNU) bool static IsGUIMode(); - virtual bool IsAppInGUIMode() const; + virtual bool IsAppInGUIMode() const Q_DECL_OVERRIDE; virtual void OpenSettings() Q_DECL_OVERRIDE; VSettings *ValentinaSettings(); diff --git a/src/app/valentina/core/vformulaproperty.h b/src/app/valentina/core/vformulaproperty.h index e6c5dcf6f..4a8c0525b 100644 --- a/src/app/valentina/core/vformulaproperty.h +++ b/src/app/valentina/core/vformulaproperty.h @@ -43,7 +43,7 @@ public: virtual QVariant data (int column = DPC_Name, int role = Qt::DisplayRole) const Q_DECL_OVERRIDE; //! Returns item flags - Qt::ItemFlags flags(int column = DPC_Name) const; + virtual Qt::ItemFlags flags(int column = DPC_Name) const Q_DECL_OVERRIDE; //! Returns an editor widget, or NULL if it doesn't supply one //! \param parent The widget to which the editor will be added as a child diff --git a/src/app/valentina/core/vformulapropertyeditor.h b/src/app/valentina/core/vformulapropertyeditor.h index 062d5b380..a8dbdc09e 100644 --- a/src/app/valentina/core/vformulapropertyeditor.h +++ b/src/app/valentina/core/vformulapropertyeditor.h @@ -52,7 +52,7 @@ public: VFormula GetFormula() const; //! Needed for proper event handling - bool eventFilter(QObject *obj, QEvent *ev); + virtual bool eventFilter(QObject *obj, QEvent *ev) Q_DECL_OVERRIDE; signals: //! This is emitted, when the user changes the color diff --git a/src/app/valentina/xml/vpattern.h b/src/app/valentina/xml/vpattern.h index 92c57cd13..a08c7b362 100644 --- a/src/app/valentina/xml/vpattern.h +++ b/src/app/valentina/xml/vpattern.h @@ -93,7 +93,7 @@ public: static const QString AttrReadOnly; public slots: - void LiteParseTree(const Document &parse); + virtual void LiteParseTree(const Document &parse) Q_DECL_OVERRIDE; protected: virtual void customEvent(QEvent * event) Q_DECL_OVERRIDE; diff --git a/src/libs/ifc/exception/vexception.h b/src/libs/ifc/exception/vexception.h index c3fb3e056..20e79217a 100644 --- a/src/libs/ifc/exception/vexception.h +++ b/src/libs/ifc/exception/vexception.h @@ -54,7 +54,7 @@ public: QString WhatUtf8() const V_NOEXCEPT_EXPR (true); void AddMoreInformation(const QString &info); QString MoreInformation() const; - virtual const char* what() const V_NOEXCEPT_EXPR (true); + virtual const char* what() const V_NOEXCEPT_EXPR (true) Q_DECL_OVERRIDE; protected: /** @brief error string with error */ diff --git a/src/libs/ifc/xml/vpatternconverter.h b/src/libs/ifc/xml/vpatternconverter.h index 1a4de28d8..9cf256872 100644 --- a/src/libs/ifc/xml/vpatternconverter.h +++ b/src/libs/ifc/xml/vpatternconverter.h @@ -48,7 +48,7 @@ protected: virtual QString MinVerStr() const Q_DECL_OVERRIDE; virtual QString MaxVerStr() const Q_DECL_OVERRIDE; - QString XSDSchema(int ver) const; + virtual QString XSDSchema(int ver) const Q_DECL_OVERRIDE; virtual void ApplyPatches() Q_DECL_OVERRIDE; virtual void DowngradeToCurrentMaxVersion() Q_DECL_OVERRIDE; diff --git a/src/libs/ifc/xml/vvitconverter.h b/src/libs/ifc/xml/vvitconverter.h index befde03e0..ac6fa638e 100644 --- a/src/libs/ifc/xml/vvitconverter.h +++ b/src/libs/ifc/xml/vvitconverter.h @@ -48,7 +48,7 @@ protected: virtual QString MinVerStr() const Q_DECL_OVERRIDE; virtual QString MaxVerStr() const Q_DECL_OVERRIDE; - QString XSDSchema(int ver) const; + virtual QString XSDSchema(int ver) const Q_DECL_OVERRIDE; virtual void ApplyPatches() Q_DECL_OVERRIDE; virtual void DowngradeToCurrentMaxVersion() Q_DECL_OVERRIDE; diff --git a/src/libs/ifc/xml/vvstconverter.h b/src/libs/ifc/xml/vvstconverter.h index e6ed806ee..2d1672250 100644 --- a/src/libs/ifc/xml/vvstconverter.h +++ b/src/libs/ifc/xml/vvstconverter.h @@ -48,7 +48,7 @@ protected: virtual QString MinVerStr() const Q_DECL_OVERRIDE; virtual QString MaxVerStr() const Q_DECL_OVERRIDE; - QString XSDSchema(int ver) const; + virtual QString XSDSchema(int ver) const Q_DECL_OVERRIDE; virtual void ApplyPatches() Q_DECL_OVERRIDE; virtual void DowngradeToCurrentMaxVersion() Q_DECL_OVERRIDE; diff --git a/src/libs/vdxf/dxflib/dl_entities.h b/src/libs/vdxf/dxflib/dl_entities.h index ca2248809..34a16202d 100644 --- a/src/libs/vdxf/dxflib/dl_entities.h +++ b/src/libs/vdxf/dxflib/dl_entities.h @@ -844,6 +844,19 @@ struct DXFLIB_EXPORT DL_TextData angle(angle) {} + DL_TextData(const DL_TextData &d) + : ipx(d.ipx), ipy(d.ipy), ipz(d.ipz), + apx(d.apx), apy(d.apy), apz(d.apz), + height(d.height), xScaleFactor(d.xScaleFactor), + textGenerationFlags(d.textGenerationFlags), + hJustification(d.hJustification), + vJustification(d.vJustification), + text(d.text), + style(d.style), + angle(d.angle) + { + } + virtual ~DL_TextData() {} diff --git a/src/libs/vdxf/dxflib/dl_extrusion.h b/src/libs/vdxf/dxflib/dl_extrusion.h index 2ab9ca427..46eb8bdff 100644 --- a/src/libs/vdxf/dxflib/dl_extrusion.h +++ b/src/libs/vdxf/dxflib/dl_extrusion.h @@ -67,8 +67,6 @@ public: /** * Constructor for DXF extrusion. * - * @param direction Vector of axis along which the entity shall be extruded - * this is also the Z axis of the Entity coordinate system * @param elevation Distance of the entities XY plane from the origin of the * world coordinate system */ @@ -103,7 +101,7 @@ public: /** - * @return direction vector. + * @param dir vector. */ void getDirection(double dir[]) const { diff --git a/src/libs/vdxf/dxflib/dl_writer_ascii.cpp b/src/libs/vdxf/dxflib/dl_writer_ascii.cpp index bb90536e6..ccc27e834 100644 --- a/src/libs/vdxf/dxflib/dl_writer_ascii.cpp +++ b/src/libs/vdxf/dxflib/dl_writer_ascii.cpp @@ -79,7 +79,7 @@ void DL_WriterA::dxfReal(int gc, double value) const // Cut away those zeros at the end: bool dot = false; int end = -1; - for (quint32 i=0, sz = strlen(str); i(strlen(str)); i GetPoints () const; + virtual QVector GetPoints () const Q_DECL_OVERRIDE; QPointF CutArc (const qreal &length, VArc &arc1, VArc &arc2) const; QPointF CutArc (const qreal &length) const; virtual void setId(const quint32 &id) Q_DECL_OVERRIDE; diff --git a/src/libs/vgeometry/vellipticalarc.h b/src/libs/vgeometry/vellipticalarc.h index b2d608c20..a52ac3884 100644 --- a/src/libs/vgeometry/vellipticalarc.h +++ b/src/libs/vgeometry/vellipticalarc.h @@ -81,14 +81,14 @@ public: QString GetFormulaLength () const; void SetFormulaLength (const QString &formula, qreal value); - qreal GetLength () const; + virtual qreal GetLength () const Q_DECL_OVERRIDE; QPointF GetP1() const; QPointF GetP2 () const; qreal AngleArc() const; QVector GetAngles () const; - QVector GetPoints () const; + virtual QVector GetPoints () const Q_DECL_OVERRIDE; QPointF CutArc (const qreal &length, VEllipticalArc &arc1, VEllipticalArc &arc2) const; QPointF CutArc (const qreal &length) const; virtual void setId(const quint32 &id) Q_DECL_OVERRIDE; diff --git a/src/libs/vgeometry/vspline.cpp b/src/libs/vgeometry/vspline.cpp index 9fb3eef30..51d1b839a 100644 --- a/src/libs/vgeometry/vspline.cpp +++ b/src/libs/vgeometry/vspline.cpp @@ -96,8 +96,6 @@ VSpline::VSpline (VPointF p1, QPointF p2, QPointF p3, VPointF p4, quint32 idObje * @param c1LengthFormula formula length from first point to first control point. * @param c2Length length from second point to first control point. * @param c2LengthFormula formula length from second point to first control point. - * @param idObject - * @param mode */ VSpline::VSpline(VPointF p1, VPointF p4, qreal angle1, const QString &angle1Formula, qreal angle2, const QString &angle2Formula, qreal c1Length, const QString &c1LengthFormula, qreal c2Length, diff --git a/src/libs/vlayout/vlayoutgenerator.cpp b/src/libs/vlayout/vlayoutgenerator.cpp index 99ec8dc1f..c914057ee 100644 --- a/src/libs/vlayout/vlayoutgenerator.cpp +++ b/src/libs/vlayout/vlayoutgenerator.cpp @@ -299,7 +299,7 @@ void VLayoutGenerator::GatherPages() VLayoutPaper paper(PageHeight(), PageWidth()); paper.SetShift(shift); paper.SetLayoutWidth(bank->GetLayoutWidth()); - paper.SetPaperIndex(i); + paper.SetPaperIndex(static_cast(i)); paper.SetRotate(rotate); paper.SetRotationIncrease(rotationIncrease); paper.SetSaveLength(saveLength); @@ -361,7 +361,7 @@ void VLayoutGenerator::UnitePages() VLayoutPaper paper(qFloor(papersLength.at(i)), PageWidth()); paper.SetShift(shift); paper.SetLayoutWidth(bank->GetLayoutWidth()); - paper.SetPaperIndex(i); + paper.SetPaperIndex(static_cast(i)); paper.SetRotate(rotate); paper.SetRotationIncrease(rotationIncrease); paper.SetSaveLength(saveLength); diff --git a/src/libs/vpropertyexplorer/plugins/Vector3d/vvector3dproperty.h b/src/libs/vpropertyexplorer/plugins/Vector3d/vvector3dproperty.h index 0da181c86..eb256f78f 100644 --- a/src/libs/vpropertyexplorer/plugins/Vector3d/vvector3dproperty.h +++ b/src/libs/vpropertyexplorer/plugins/Vector3d/vvector3dproperty.h @@ -61,7 +61,7 @@ public: virtual QVariant data (int column = DPC_Name, int role = Qt::DisplayRole) const Q_DECL_OVERRIDE; //! Returns item flags - Qt::ItemFlags flags(int column = DPC_Name) const; + virtual Qt::ItemFlags flags(int column = DPC_Name) const Q_DECL_OVERRIDE; //! Returns the Vector3d virtual Vector3D getVector() const; diff --git a/src/libs/vpropertyexplorer/plugins/vcolorpropertyeditor.h b/src/libs/vpropertyexplorer/plugins/vcolorpropertyeditor.h index bbd7b0e40..05760823c 100644 --- a/src/libs/vpropertyexplorer/plugins/vcolorpropertyeditor.h +++ b/src/libs/vpropertyexplorer/plugins/vcolorpropertyeditor.h @@ -59,7 +59,7 @@ public: static QString GetColorString(const QColor& color); //! Needed for proper event handling - bool eventFilter(QObject *obj, QEvent *ev); + virtual bool eventFilter(QObject *obj, QEvent *ev) Q_DECL_OVERRIDE; signals: //! This is emitted, when the user changes the color diff --git a/src/libs/vpropertyexplorer/plugins/vfilepropertyeditor.h b/src/libs/vpropertyexplorer/plugins/vfilepropertyeditor.h index a6fcbf9b4..da0ce3e17 100644 --- a/src/libs/vpropertyexplorer/plugins/vfilepropertyeditor.h +++ b/src/libs/vpropertyexplorer/plugins/vfilepropertyeditor.h @@ -45,7 +45,7 @@ public: QString getFile() const; //! Needed for proper event handling - bool eventFilter(QObject* obj, QEvent* ev); + virtual bool eventFilter(QObject* obj, QEvent* ev) Q_DECL_OVERRIDE; //! Returns the directory/file setting //! \return True, if a directory dialog is being shown, false if a file dialog @@ -82,10 +82,10 @@ private slots: void onToolButtonClicked(); protected: - void dragEnterEvent(QDragEnterEvent* event); - void dragMoveEvent(QDragMoveEvent* event); - void dragLeaveEvent(QDragLeaveEvent* event); - void dropEvent(QDropEvent* event); + virtual void dragEnterEvent(QDragEnterEvent* event) Q_DECL_OVERRIDE; + virtual void dragMoveEvent(QDragMoveEvent* event) Q_DECL_OVERRIDE; + virtual void dragLeaveEvent(QDragLeaveEvent* event) Q_DECL_OVERRIDE; + virtual void dropEvent(QDropEvent* event) Q_DECL_OVERRIDE; //! This function checks the mime data, if it is compatible with the filters virtual bool checkMimeData(const QMimeData* data, QString& getFile) const; diff --git a/src/libs/vpropertyexplorer/plugins/vshortcutpropertyeditor.h b/src/libs/vpropertyexplorer/plugins/vshortcutpropertyeditor.h index db75b531c..fa85aa7f8 100644 --- a/src/libs/vpropertyexplorer/plugins/vshortcutpropertyeditor.h +++ b/src/libs/vpropertyexplorer/plugins/vshortcutpropertyeditor.h @@ -41,7 +41,7 @@ public: virtual ~VShortcutEditWidget() Q_DECL_OVERRIDE; //! Needed for proper event handling - bool eventFilter(QObject* obj, QEvent* evenvt); + virtual bool eventFilter(QObject* obj, QEvent* evenvt) Q_DECL_OVERRIDE; //! Returns the currently set shortcut QString getShortcutAsString() const; diff --git a/src/libs/vpropertyexplorer/vpropertyformview.h b/src/libs/vpropertyexplorer/vpropertyformview.h index 3b5573b41..abe3c7592 100644 --- a/src/libs/vpropertyexplorer/vpropertyformview.h +++ b/src/libs/vpropertyexplorer/vpropertyformview.h @@ -84,7 +84,7 @@ private slots: void dataSubmitted(VProperty* property); protected: - void showEvent(QShowEvent* event); + virtual void showEvent(QShowEvent* event) Q_DECL_OVERRIDE; //! Rebuilds the widegt only if it is visible void updatePropertyList(); diff --git a/src/libs/vpropertyexplorer/vpropertymodel.h b/src/libs/vpropertyexplorer/vpropertymodel.h index aebb5938f..485ab088b 100644 --- a/src/libs/vpropertyexplorer/vpropertymodel.h +++ b/src/libs/vpropertyexplorer/vpropertymodel.h @@ -75,7 +75,7 @@ public: virtual VProperty* getProperty(const QString& id); //! Returns the item flags for the given index - virtual Qt::ItemFlags flags (const QModelIndex& index) const; + virtual Qt::ItemFlags flags (const QModelIndex& index) const Q_DECL_OVERRIDE; //! Sets the role data for the item at index to value virtual bool setData (const QModelIndex& index, const QVariant& value, int role = Qt::EditRole) Q_DECL_OVERRIDE; diff --git a/src/libs/vtools/dialogs/tools/dialogcubicbezier.cpp b/src/libs/vtools/dialogs/tools/dialogcubicbezier.cpp index ae71ca539..c33761b7e 100644 --- a/src/libs/vtools/dialogs/tools/dialogcubicbezier.cpp +++ b/src/libs/vtools/dialogs/tools/dialogcubicbezier.cpp @@ -192,8 +192,8 @@ void DialogCubicBezier::PointNameChanged() if (not data->IsUnique(spline.name())) { - newDuplicate = DNumber(spline.name()); - spline.SetDuplicate(newDuplicate); + newDuplicate = static_cast(DNumber(spline.name())); + spline.SetDuplicate(static_cast(newDuplicate)); } ui->lineEditSplineName->setText(spline.name()); } diff --git a/src/libs/vtools/dialogs/tools/dialogcubicbezierpath.cpp b/src/libs/vtools/dialogs/tools/dialogcubicbezierpath.cpp index 24ffff2b6..a53098c78 100644 --- a/src/libs/vtools/dialogs/tools/dialogcubicbezierpath.cpp +++ b/src/libs/vtools/dialogs/tools/dialogcubicbezierpath.cpp @@ -229,8 +229,8 @@ void DialogCubicBezierPath::currentPointChanged(int index) if (not data->IsUnique(newPath.name())) { - newDuplicate = DNumber(newPath.name()); - newPath.SetDuplicate(newDuplicate); + newDuplicate = static_cast(DNumber(newPath.name())); + newPath.SetDuplicate(static_cast(newDuplicate)); } ui->lineEditSplPathName->setText(newPath.name()); diff --git a/src/libs/vtools/dialogs/tools/dialogspline.cpp b/src/libs/vtools/dialogs/tools/dialogspline.cpp index fdc42c3e1..2a893b92e 100644 --- a/src/libs/vtools/dialogs/tools/dialogspline.cpp +++ b/src/libs/vtools/dialogs/tools/dialogspline.cpp @@ -483,8 +483,8 @@ void DialogSpline::PointNameChanged() if (not data->IsUnique(spline.name())) { - newDuplicate = DNumber(spline.name()); - spline.SetDuplicate(newDuplicate); + newDuplicate = static_cast(DNumber(spline.name())); + spline.SetDuplicate(static_cast(newDuplicate)); } ui->lineEditSplineName->setText(spline.name()); } diff --git a/src/libs/vtools/dialogs/tools/dialogsplinepath.cpp b/src/libs/vtools/dialogs/tools/dialogsplinepath.cpp index abf519d32..1a4771378 100644 --- a/src/libs/vtools/dialogs/tools/dialogsplinepath.cpp +++ b/src/libs/vtools/dialogs/tools/dialogsplinepath.cpp @@ -677,8 +677,8 @@ void DialogSplinePath::currentPointChanged(int index) if (not data->IsUnique(newPath.name())) { - newDuplicate = DNumber(newPath.name()); - newPath.SetDuplicate(newDuplicate); + newDuplicate = static_cast(DNumber(newPath.name())); + newPath.SetDuplicate(static_cast(newDuplicate)); } ui->lineEditSplPathName->setText(newPath.name()); diff --git a/src/libs/vtools/dialogs/tools/dialogtool.h b/src/libs/vtools/dialogs/tools/dialogtool.h index 2eeec1370..e1c51a5da 100644 --- a/src/libs/vtools/dialogs/tools/dialogtool.h +++ b/src/libs/vtools/dialogs/tools/dialogtool.h @@ -250,7 +250,7 @@ protected: */ virtual void SaveData() {} void MoveCursorToEnd(QPlainTextEdit *plainTextEdit); - bool eventFilter(QObject *object, QEvent *event); + virtual bool eventFilter(QObject *object, QEvent *event) Q_DECL_OVERRIDE; quint32 DNumber(const QString &baseName) const; private: void FillList(QComboBox *box, const QMap &list)const; diff --git a/src/libs/vtools/dialogs/tools/dialogtriangle.h b/src/libs/vtools/dialogs/tools/dialogtriangle.h index 01ad7c42b..8fd47ee2b 100644 --- a/src/libs/vtools/dialogs/tools/dialogtriangle.h +++ b/src/libs/vtools/dialogs/tools/dialogtriangle.h @@ -63,7 +63,7 @@ public slots: virtual void ChosenObject(quint32 id, const SceneObject &type) Q_DECL_OVERRIDE; virtual void PointNameChanged() Q_DECL_OVERRIDE; protected: - virtual void ShowVisualization(); + virtual void ShowVisualization() Q_DECL_OVERRIDE; /** * @brief SaveData Put dialog data in local variables */ diff --git a/src/libs/vtools/dialogs/tools/dialoguniondetails.h b/src/libs/vtools/dialogs/tools/dialoguniondetails.h index 03c6e7f86..5f7290d6a 100644 --- a/src/libs/vtools/dialogs/tools/dialoguniondetails.h +++ b/src/libs/vtools/dialogs/tools/dialoguniondetails.h @@ -51,7 +51,7 @@ public: int getIndexD1() const; int getIndexD2() const; public slots: - void ChosenObject(quint32 id, const SceneObject &type); + virtual void ChosenObject(quint32 id, const SceneObject &type) Q_DECL_OVERRIDE; private: Q_DISABLE_COPY(DialogUnionDetails) diff --git a/src/libs/vtools/tools/drawTools/toolcurve/vtoolsplinepath.cpp b/src/libs/vtools/tools/drawTools/toolcurve/vtoolsplinepath.cpp index 17dc867dd..2456396d9 100644 --- a/src/libs/vtools/tools/drawTools/toolcurve/vtoolsplinepath.cpp +++ b/src/libs/vtools/tools/drawTools/toolcurve/vtoolsplinepath.cpp @@ -289,7 +289,7 @@ void VToolSplinePath::SetSplinePathAttributes(QDomElement &domElement, const VSp /** * @brief UpdatePathPoints update spline path in pattern file. * @param doc dom document container. - * @param node tag in file. + * @param element tag in file. * @param path spline path. */ void VToolSplinePath::UpdatePathPoints(VAbstractPattern *doc, QDomElement &element, const VSplinePath &path) diff --git a/src/libs/vtools/tools/drawTools/toolpoint/toolsinglepoint/vtoolbasepoint.h b/src/libs/vtools/tools/drawTools/toolpoint/toolsinglepoint/vtoolbasepoint.h index e817dc982..5c6b57f60 100644 --- a/src/libs/vtools/tools/drawTools/toolpoint/toolsinglepoint/vtoolbasepoint.h +++ b/src/libs/vtools/tools/drawTools/toolpoint/toolsinglepoint/vtoolbasepoint.h @@ -63,7 +63,7 @@ signals: protected: virtual void contextMenuEvent ( QGraphicsSceneContextMenuEvent * event ) Q_DECL_OVERRIDE; virtual void AddToFile() Q_DECL_OVERRIDE; - QVariant itemChange ( GraphicsItemChange change, const QVariant &value ); + virtual QVariant itemChange ( GraphicsItemChange change, const QVariant &value ) Q_DECL_OVERRIDE; virtual void DeleteTool(bool ask = true) Q_DECL_OVERRIDE; virtual void SaveDialog(QDomElement &domElement) Q_DECL_OVERRIDE; virtual void hoverEnterEvent ( QGraphicsSceneHoverEvent * event ) Q_DECL_OVERRIDE; diff --git a/src/libs/vtools/tools/nodeDetails/vabstractnode.h b/src/libs/vtools/tools/nodeDetails/vabstractnode.h index 9ebc987ce..ac9119b08 100644 --- a/src/libs/vtools/tools/nodeDetails/vabstractnode.h +++ b/src/libs/vtools/tools/nodeDetails/vabstractnode.h @@ -69,7 +69,7 @@ protected: QColor currentColor; void AddToModeling(const QDomElement &domElement); - virtual void SetVisualization() {} + virtual void SetVisualization() Q_DECL_OVERRIDE {} virtual void ShowNode()=0; virtual void HideNode()=0; diff --git a/src/libs/vtools/tools/nodeDetails/vnodearc.cpp b/src/libs/vtools/tools/nodeDetails/vnodearc.cpp index d252c5a24..a0f53931a 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodearc.cpp +++ b/src/libs/vtools/tools/nodeDetails/vnodearc.cpp @@ -44,7 +44,6 @@ const QString VNodeArc::ToolType = QStringLiteral("modeling"); * @param typeCreation way we create this tool. * @param idTool tool id. * @param qoParent QObject parent - * @param parent parent object. */ VNodeArc::VNodeArc(VAbstractPattern *doc, VContainer *data, quint32 id, quint32 idArc, const Source &typeCreation, const quint32 &idTool, QObject *qoParent) @@ -63,7 +62,6 @@ VNodeArc::VNodeArc(VAbstractPattern *doc, VContainer *data, quint32 id, quint32 * @param parse parser file mode. * @param typeCreation way we create this tool. * @param idTool tool id. - * @param parent QObject parent */ void VNodeArc::Create(VAbstractPattern *doc, VContainer *data, quint32 id, quint32 idArc, const Document &parse, const Source &typeCreation, const quint32 &idTool) diff --git a/src/libs/vtools/tools/nodeDetails/vnodepoint.cpp b/src/libs/vtools/tools/nodeDetails/vnodepoint.cpp index ba8215936..9b22b2337 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodepoint.cpp +++ b/src/libs/vtools/tools/nodeDetails/vnodepoint.cpp @@ -77,7 +77,6 @@ VNodePoint::VNodePoint(VAbstractPattern *doc, VContainer *data, quint32 id, quin * @param parse parser file mode. * @param typeCreation way we create this tool. * @param idTool tool id. - * @param parent QObject parent */ void VNodePoint::Create(VAbstractPattern *doc, VContainer *data, VMainGraphicsScene *scene, quint32 id, quint32 idPoint, const Document &parse, diff --git a/src/libs/vtools/tools/nodeDetails/vnodespline.cpp b/src/libs/vtools/tools/nodeDetails/vnodespline.cpp index 393c63cfd..2690e01df 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodespline.cpp +++ b/src/libs/vtools/tools/nodeDetails/vnodespline.cpp @@ -44,7 +44,6 @@ const QString VNodeSpline::ToolType = QStringLiteral("modelingSpline"); * @param typeCreation way we create this tool. * @param idTool id node. * @param qoParent QObject parent. - * @param parent QGraphicsItem parent. */ VNodeSpline::VNodeSpline(VAbstractPattern *doc, VContainer *data, quint32 id, quint32 idSpline, const Source &typeCreation, const quint32 &idTool, QObject *qoParent) diff --git a/src/libs/vtools/tools/nodeDetails/vnodesplinepath.cpp b/src/libs/vtools/tools/nodeDetails/vnodesplinepath.cpp index 32ffdda54..91a7f7e4d 100644 --- a/src/libs/vtools/tools/nodeDetails/vnodesplinepath.cpp +++ b/src/libs/vtools/tools/nodeDetails/vnodesplinepath.cpp @@ -45,7 +45,6 @@ const QString VNodeSplinePath::ToolType = QStringLiteral("modelingPath"); * @param typeCreation way we create this tool. * @param idTool tool id. * @param qoParent QObject parent. - * @param parent parent object. */ VNodeSplinePath::VNodeSplinePath(VAbstractPattern *doc, VContainer *data, quint32 id, quint32 idSpline, const Source &typeCreation, const quint32 &idTool, QObject *qoParent) @@ -64,7 +63,6 @@ VNodeSplinePath::VNodeSplinePath(VAbstractPattern *doc, VContainer *data, quint3 * @param parse parser file mode. * @param typeCreation way we create this tool. * @param idTool tool id. - * @param parent QObject parent. */ void VNodeSplinePath::Create(VAbstractPattern *doc, VContainer *data, quint32 id, quint32 idSpline, const Document &parse, const Source &typeCreation, const quint32 &idTool) diff --git a/src/libs/vtools/tools/vtooluniondetails.cpp b/src/libs/vtools/tools/vtooluniondetails.cpp index f0706e462..585dd541b 100644 --- a/src/libs/vtools/tools/vtooluniondetails.cpp +++ b/src/libs/vtools/tools/vtooluniondetails.cpp @@ -90,7 +90,6 @@ VToolUnionDetails::VToolUnionDetails(VAbstractPattern *doc, VContainer *data, co //--------------------------------------------------------------------------------------------------------------------- /** * @brief AddToNewDetail create united detail adding one node per time. - * @param tool tool that make union. * @param doc dom document container. * @param data container with variables. * @param newDetail united detail. @@ -278,7 +277,6 @@ void VToolUnionDetails::AddToNewDetail(VMainGraphicsScene *scene, VAbstractPatte //--------------------------------------------------------------------------------------------------------------------- /** * @brief UpdatePoints update data for united details. - * @param idDetail id united detail. * @param data container with variables. * @param det detail what we union. * @param i index node in detail. diff --git a/src/libs/vwidgets/vgraphicssimpletextitem.h b/src/libs/vwidgets/vgraphicssimpletextitem.h index 031879075..44c164e04 100644 --- a/src/libs/vwidgets/vgraphicssimpletextitem.h +++ b/src/libs/vwidgets/vgraphicssimpletextitem.h @@ -65,7 +65,7 @@ signals: void PointChoosed(); void PointSelected(bool selected); protected: - QVariant itemChange ( GraphicsItemChange change, const QVariant &value ); + virtual QVariant itemChange ( GraphicsItemChange change, const QVariant &value ) Q_DECL_OVERRIDE; virtual void hoverEnterEvent ( QGraphicsSceneHoverEvent *event ) Q_DECL_OVERRIDE; virtual void hoverLeaveEvent ( QGraphicsSceneHoverEvent *event ) Q_DECL_OVERRIDE; virtual void contextMenuEvent ( QGraphicsSceneContextMenuEvent *event ) Q_DECL_OVERRIDE;