From 5f8b46da5b74362564021c4264874e275ad0b79a Mon Sep 17 00:00:00 2001
From: Roman Telezhynskyi <dismine@gmail.com>
Date: Thu, 18 Aug 2022 17:09:12 +0300
Subject: [PATCH] Refactor VPMainWindow::GeneratePdfTiledFile.

It should return result to stop generation in case of an error.
---
 src/app/puzzle/vpmainwindow.cpp | 22 +++++++++++++++-------
 src/app/puzzle/vpmainwindow.h   |  4 ++--
 2 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/src/app/puzzle/vpmainwindow.cpp b/src/app/puzzle/vpmainwindow.cpp
index 4d1b6c9c3..7de00acac 100644
--- a/src/app/puzzle/vpmainwindow.cpp
+++ b/src/app/puzzle/vpmainwindow.cpp
@@ -2574,7 +2574,10 @@ void VPMainWindow::ExportPdfTiledFile(const VPExportData &data)
         bool firstPage = true;
         for (const auto& sheet : data.sheets)
         {
-            GeneratePdfTiledFile(sheet, data.showTilesScheme, &painter, printer, firstPage);
+            if (not GeneratePdfTiledFile(sheet, data.showTilesScheme, &painter, printer, firstPage))
+            {
+                break;
+            }
         }
     }
     else
@@ -2589,14 +2592,17 @@ void VPMainWindow::ExportPdfTiledFile(const VPExportData &data)
 
             QPainter painter;
             bool firstPage = true;
-            GeneratePdfTiledFile(data.sheets.at(i), data.showTilesScheme, &painter, printer, firstPage);
+            if (not GeneratePdfTiledFile(data.sheets.at(i), data.showTilesScheme, &painter, printer, firstPage))
+            {
+                break;
+            }
         }
     }
 }
 
 //---------------------------------------------------------------------------------------------------------------------
-void VPMainWindow::GeneratePdfTiledFile(const VPSheetPtr &sheet, bool showTilesScheme, QPainter *painter,
-                                        const QSharedPointer<QPrinter> &printer, bool &firstPage)
+auto VPMainWindow::GeneratePdfTiledFile(const VPSheetPtr &sheet, bool showTilesScheme, QPainter *painter,
+                                        const QSharedPointer<QPrinter> &printer, bool &firstPage) -> bool
 {
     SCASSERT(not sheet.isNull())
     SCASSERT(painter != nullptr)
@@ -2621,7 +2627,7 @@ void VPMainWindow::GeneratePdfTiledFile(const VPSheetPtr &sheet, bool showTilesS
         if (not painter->begin(printer.data()))
         { // failed to open file
             qCritical() << tr("Failed to open file, is it writable?");
-            return;
+            return false;
         }
 
         painter->setPen(QPen(Qt::black, VAbstractApplication::VApp()->Settings()->WidthMainLine(), Qt::SolidLine,
@@ -2634,7 +2640,7 @@ void VPMainWindow::GeneratePdfTiledFile(const VPSheetPtr &sheet, bool showTilesS
     {
         if (not DrawTilesScheme(printer.data(), painter, sheet, firstPage))
         {
-            return;
+            return false;
         }
         firstPage = false;
     }
@@ -2651,7 +2657,7 @@ void VPMainWindow::GeneratePdfTiledFile(const VPSheetPtr &sheet, bool showTilesS
                 if (not printer->newPage())
                 {
                     qWarning("failed in flushing page to disk, disk full?");
-                    return;
+                    return false;
                 }
             }
 
@@ -2662,6 +2668,8 @@ void VPMainWindow::GeneratePdfTiledFile(const VPSheetPtr &sheet, bool showTilesS
     }
 
     sheet->SceneData()->CleanAfterExport();
+
+    return true;
 }
 
 //---------------------------------------------------------------------------------------------------------------------
diff --git a/src/app/puzzle/vpmainwindow.h b/src/app/puzzle/vpmainwindow.h
index 52d40c736..993cdc462 100644
--- a/src/app/puzzle/vpmainwindow.h
+++ b/src/app/puzzle/vpmainwindow.h
@@ -479,8 +479,8 @@ private:
     static void ExportUnifiedPdfFile(const VPExportData &data);
     static void GenerateUnifiedPdfFile(const VPExportData &data, const QString &name);
     void ExportPdfTiledFile(const VPExportData &data);
-    void GeneratePdfTiledFile(const VPSheetPtr &sheet, bool showTilesScheme, QPainter *painter,
-                              const QSharedPointer<QPrinter> &printer, bool &firstPage);
+    auto GeneratePdfTiledFile(const VPSheetPtr &sheet, bool showTilesScheme, QPainter *painter,
+                              const QSharedPointer<QPrinter> &printer, bool &firstPage) -> bool;
 
     void UpdateScaleConnection() const;