aw/valentina
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix error in VDomDocument::elementById.

Browse Source 
Searching in cache did not check tag if provided.
This commit is contained in:
Roman Telezhynskyi 2020-03-18 14:29:28 +02:00
parent b756460da8
commit 4fa2b76f01
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/libs/ifc/xml/vdomdocument.cpp
View File

@ -273,11 +273,21 @@ QDomElement VDomDocument::elementById(quint32 id, const QString &tagName, bool u
if (m_elementIdCache.contains(id)) if (m_elementIdCache.contains(id))
{ {
const QDomElement e = m_elementIdCache.value(id); const QDomElement e = m_elementIdCache.value(id);
if (e.parentNode().nodeType() != QDomNode::BaseNode) if (e.parentNode().nodeType() != QDomNode::BaseNode)
{ {
return e; if (not tagName.isEmpty())
} {
if (e.tagName() == tagName)
{
return e;
}
}
else
{
return e;
}
}
} }
if (updateCache) if (updateCache)