From 43b6125edd52355750bae618566c5aa2db20badb Mon Sep 17 00:00:00 2001
From: Roman Telezhynskyi <kroluku@gmail.com>
Date: Mon, 16 Sep 2019 11:54:55 +0300
Subject: [PATCH] Fixed issue #978. Don't show errors in History dialog.

Showing error messages instead of tool record can confuse a user. Additionally
it may create issues with a caret (feature insert after).
(grafted from 33a0a02a8ff5904b0226cbc1e94f36619db45212)

--HG--
branch : develop
---
 ChangeLog.txt                               | 1 +
 src/app/valentina/dialogs/dialoghistory.cpp | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/ChangeLog.txt b/ChangeLog.txt
index 2a362e758..c1d3471cd 100644
--- a/ChangeLog.txt
+++ b/ChangeLog.txt
@@ -64,6 +64,7 @@
 - Changing settings for move and rotate tools through property browser does not take in count previous change for label point and Show label option.
 - Fix locking file after double save as.
 - Key --ignoremargins still required margins.
+- [#978] Don't show errors in History dialog.
 
 # Version 0.6.1 October 23, 2018
 - [#885] Regression. Broken support for multi size measurements.
diff --git a/src/app/valentina/dialogs/dialoghistory.cpp b/src/app/valentina/dialogs/dialoghistory.cpp
index ea55d1218..6591a8672 100644
--- a/src/app/valentina/dialogs/dialoghistory.cpp
+++ b/src/app/valentina/dialogs/dialoghistory.cpp
@@ -218,7 +218,7 @@ QString DialogHistory::Record(const VToolRecord &tool)
     if (domElem.isElement() == false)
     {
         qDebug()<<"Can't find element by id"<<Q_FUNC_INFO;
-        return tr("Can't create record.");
+        return QString();
     }
     try
     {
@@ -418,10 +418,10 @@ QString DialogHistory::Record(const VToolRecord &tool)
     catch (const VExceptionBadId &e)
     {
         qDebug()<<e.ErrorMessage()<<Q_FUNC_INFO;
-        return tr("Can't create record.");
+        return QString();
     }
     qDebug()<<"Can't create history record for the tool.";
-    return tr("Can't create record.");
+    return QString();
 }
 
 QT_WARNING_POP