aw/valentina
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed issue #978. Don't show errors in History dialog.

Browse Source 
Showing error messages instead of tool record can confuse a user. Additionally
it may create issues with a caret (feature insert after).

--HG--
branch : release
This commit is contained in:
Roman Telezhynskyi 2019-09-16 11:54:55 +03:00
parent d44ceda840
commit 3db4f4ef6d
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ChangeLog.txt
View File

@ -30,6 +30,7 @@
- Changing settings for move and rotate tools through property browser does not take in count previous change for label point and Show label option. - Changing settings for move and rotate tools through property browser does not take in count previous change for label point and Show label option.
- Fix locking file after double save as. - Fix locking file after double save as.
- Key --ignoremargins still required margins. - Key --ignoremargins still required margins.
- [#978] Don't show errors in History dialog.
# Version 0.6.1 October 23, 2018 # Version 0.6.1 October 23, 2018
- [#885] Regression. Broken support for multi size measurements. - [#885] Regression. Broken support for multi size measurements.

6
src/app/valentina/dialogs/dialoghistory.cpp
View File

@ -218,7 +218,7 @@ QString DialogHistory::Record(const VToolRecord &tool)
if (domElem.isElement() == false) if (domElem.isElement() == false)
{ {
qDebug()<<"Can't find element by id"<<Q_FUNC_INFO; qDebug()<<"Can't find element by id"<<Q_FUNC_INFO;
return tr("Can't create record."); return QString();
} }
try try
{ {
@ -407,10 +407,10 @@ QString DialogHistory::Record(const VToolRecord &tool)
catch (const VExceptionBadId &e) catch (const VExceptionBadId &e)
{ {
qDebug()<<e.ErrorMessage()<<Q_FUNC_INFO; qDebug()<<e.ErrorMessage()<<Q_FUNC_INFO;
return tr("Can't create record."); return QString();
} }
qDebug()<<"Can't create history record for the tool."; qDebug()<<"Can't create history record for the tool.";
return tr("Can't create record."); return QString();
} }
QT_WARNING_POP QT_WARNING_POP