aw/valentina
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

This check helps to find missed tools in the switch.

Browse Source 
--HG--
branch : develop
This commit is contained in:
Roman Telezhynskyi 2016-03-13 16:16:49 +02:00
parent 5befd6770b
commit 2201ca9ec0
2 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/app/valentina/dialogs/dialoghistory.cpp
View File

@ -207,6 +207,9 @@ void DialogHistory::FillTable()
*/ */
QString DialogHistory::Record(const VToolRecord &tool) QString DialogHistory::Record(const VToolRecord &tool)
{ {
// This check helps to find missed tools in the switch
Q_STATIC_ASSERT_X(static_cast<int>(Tool::LAST_ONE_DO_NOT_USE) == 40, "Not all tools was used in history.");
const QDomElement domElem = doc->elementById(tool.getId()); const QDomElement domElem = doc->elementById(tool.getId());
if (domElem.isElement() == false) if (domElem.isElement() == false)
{ {

39
src/app/valentina/xml/vpattern.cpp
View File

@ -3030,6 +3030,9 @@ void VPattern::ToolsCommonAttributes(const QDomElement &domElement, quint32 &id)
//--------------------------------------------------------------------------------------------------------------------- //---------------------------------------------------------------------------------------------------------------------
QRectF VPattern::ActiveDrawBoundingRect() const QRectF VPattern::ActiveDrawBoundingRect() const
{ {
// This check helps to find missed tools in the switch
Q_STATIC_ASSERT_X(static_cast<int>(Tool::LAST_ONE_DO_NOT_USE) == 40, "Not all tools was used.");
QRectF rec; QRectF rec;
for (qint32 i = 0; i< history.size(); ++i) for (qint32 i = 0; i< history.size(); ++i)
@ -3040,6 +3043,12 @@ QRectF VPattern::ActiveDrawBoundingRect() const
switch ( tool.getTypeTool() ) switch ( tool.getTypeTool() )
{ {
case Tool::Arrow: case Tool::Arrow:
case Tool::SinglePoint:
case Tool::DoublePoint:
case Tool::LinePoint:
case Tool::AbstractSpline:
case Tool::Cut:
case Tool::LAST_ONE_DO_NOT_USE:
Q_UNREACHABLE(); Q_UNREACHABLE();
break; break;
case Tool::BasePoint: case Tool::BasePoint:
@ -3069,6 +3078,9 @@ QRectF VPattern::ActiveDrawBoundingRect() const
case Tool::Spline: case Tool::Spline:
rec = ToolBoundingRect<VToolSpline>(rec, tool.getId()); rec = ToolBoundingRect<VToolSpline>(rec, tool.getId());
break; break;
case Tool::CubicBezier:
rec = ToolBoundingRect<VToolCubicBezier>(rec, tool.getId());
break;
case Tool::Arc: case Tool::Arc:
rec = ToolBoundingRect<VToolArc>(rec, tool.getId()); rec = ToolBoundingRect<VToolArc>(rec, tool.getId());
break; break;
@ -3096,6 +3108,33 @@ QRectF VPattern::ActiveDrawBoundingRect() const
case Tool::CutSplinePath: case Tool::CutSplinePath:
rec = ToolBoundingRect<VToolCutSplinePath>(rec, tool.getId()); rec = ToolBoundingRect<VToolCutSplinePath>(rec, tool.getId());
break; break;
case Tool::ArcWithLength:
rec = ToolBoundingRect<VToolArcWithLength>(rec, tool.getId());
break;
case Tool::LineIntersectAxis:
rec = ToolBoundingRect<VToolLineIntersectAxis>(rec, tool.getId());
break;
case Tool::PointOfIntersectionArcs:
rec = ToolBoundingRect<VToolPointOfIntersectionArcs>(rec, tool.getId());
break;
case Tool::PointOfIntersectionCircles:
rec = ToolBoundingRect<VToolPointOfIntersectionCircles>(rec, tool.getId());
break;
case Tool::PointOfIntersectionCurves:
rec = ToolBoundingRect<VToolPointOfIntersectionCurves>(rec, tool.getId());
break;
case Tool::CurveIntersectAxis:
rec = ToolBoundingRect<VToolCurveIntersectAxis>(rec, tool.getId());
break;
case Tool::PointFromCircleAndTangent:
rec = ToolBoundingRect<VToolPointFromCircleAndTangent>(rec, tool.getId());
break;
case Tool::PointFromArcAndTangent:
rec = ToolBoundingRect<VToolPointFromArcAndTangent>(rec, tool.getId());
break;
case Tool::TrueDarts:
rec = ToolBoundingRect<VToolTrueDarts>(rec, tool.getId());
break;
//Because "history" not only show history of pattern, but help restore current data for each pattern's //Because "history" not only show history of pattern, but help restore current data for each pattern's
//piece, we need add record about details and nodes, but don't show them. //piece, we need add record about details and nodes, but don't show them.
case Tool::Detail: case Tool::Detail: