aw/valentina
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Refactoring.

Browse Source 
Avoid unnecessary copy by using a "const" reference.
This commit is contained in:
Roman Telezhynskyi 2024-04-16 17:12:32 +03:00
parent 0080ce8ef5
commit 1ddb07f2ee
5 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/app/puzzle/xml/vplayoutfilewriter.cpp
View File

@ -95,7 +95,7 @@ auto LinesToString(const QVector<QLineF> &lines) -> QString
{ {
QStringList l; QStringList l;
l.reserve(lines.size()); l.reserve(lines.size());
for (auto line : lines) for (const auto &line : lines)
{ {
l.append(LineToString(line)); l.append(LineToString(line));
} }

2
src/libs/vgeometry/vabstractcurve.cpp
View File

@ -611,7 +611,7 @@ auto VAbstractCurve::ShowDirection(const QVector<DirectionArrow> &arrows, qreal
{ {
QPainterPath path; QPainterPath path;
for (auto arrow : arrows) for (const auto &arrow : arrows)
{ {
if (not arrow.first.isNull() && not arrow.second.isNull()) if (not arrow.first.isNull() && not arrow.second.isNull())
{ {

2
src/libs/vpatterndb/testpassmark.cpp
View File

@ -44,7 +44,7 @@ namespace
auto PassmarkShapeToJson(const QVector<QLineF> &shape) -> QJsonArray auto PassmarkShapeToJson(const QVector<QLineF> &shape) -> QJsonArray
{ {
QJsonArray shapeArray; QJsonArray shapeArray;
for (auto line : shape) for (const auto &line : shape)
{ {
QJsonObject const lineObject{ QJsonObject const lineObject{
{"type", "QLineF"}, {"type", "QLineF"},

2
src/libs/vtools/tools/toolsdef.cpp
View File

@ -51,7 +51,7 @@ auto SourceToObjects(const QVector<SourceItem> &source) -> QVector<quint32>
QVector<quint32> ids; QVector<quint32> ids;
ids.reserve(source.size()); ids.reserve(source.size());
for (auto s : source) for (const auto &s : source)
{ {
ids.append(s.id); ids.append(s.id);
} }

10
src/test/ValentinaTest/tst_vposter.cpp
View File

@ -35,8 +35,8 @@
#include <QtTest> #include <QtTest>
//--------------------------------------------------------------------------------------------------------------------- //---------------------------------------------------------------------------------------------------------------------
TST_VPoster::TST_VPoster(QObject *parent) : TST_VPoster::TST_VPoster(QObject *parent)
QObject(parent) : QObject(parent)
{ {
} }
@ -59,7 +59,7 @@ void TST_VPoster::BigPoster()
QCOMPARE(poster.size(), 12); QCOMPARE(poster.size(), 12);
for (auto p : poster) for (const auto &p : poster)
{ {
QCOMPARE(p.rect.size(), PageRect(printer).size()); QCOMPARE(p.rect.size(), PageRect(printer).size());
} }
@ -89,8 +89,8 @@ auto TST_VPoster::PageRect(const QPrinter &printer) const -> QRect
// we can't use method pageRect(QPrinter::Point). Our dpi different can be different. // we can't use method pageRect(QPrinter::Point). Our dpi different can be different.
// We convert value yourself to pixels. // We convert value yourself to pixels.
const QRectF rect = printer.pageRect(QPrinter::Millimeter); const QRectF rect = printer.pageRect(QPrinter::Millimeter);
QRect pageRect(qFloor(ToPixel(rect.x())), qFloor(ToPixel(rect.y())), QRect pageRect(qFloor(ToPixel(rect.x())), qFloor(ToPixel(rect.y())), qFloor(ToPixel(rect.width())),
qFloor(ToPixel(rect.width())), qFloor(ToPixel(rect.height()))); qFloor(ToPixel(rect.height())));
return pageRect; return pageRect;
} }