New test. Each translated measurement name should be unique.

--HG--
branch : develop
This commit is contained in:
Roman Telezhynskyi 2015-11-03 18:19:52 +02:00
parent 00a4187eda
commit 18a3a289ff
2 changed files with 102 additions and 28 deletions

View File

@ -67,31 +67,7 @@ void TST_MeasurementRegExp::TestOriginalMeasurementNamesRegExp()
// cppcheck-suppress unusedFunction // cppcheck-suppress unusedFunction
void TST_MeasurementRegExp::TestMeasurementRegExp_data() void TST_MeasurementRegExp::TestMeasurementRegExp_data()
{ {
const int systemCounts = 56; PrepareMeasurementData();
const QStringList locales = SupportedLocales();
{
const int combinations = systemCounts * locales.size();
QDir dir(TranslationsPath());
const QStringList fileNames = dir.entryList(QStringList("measurements_p*_*.qm"));
QVERIFY2(combinations == fileNames.size(), "Unexpected count of files.");
}
QTest::addColumn<QString>("system");
QTest::addColumn<QString>("locale");
for(int s = 0; s < systemCounts; ++s)
{
for(int l = 0, sz = locales.size(); l < sz; ++l)
{
const QString system = QString("p%1").arg(s);
const QString locale = locales.at(l);
const QString tag = QString("Check translation measurements_%1_%2.qm").arg(system).arg(locale);
QTest::newRow(qUtf8Printable(tag)) << system << locale;
}
}
} }
//--------------------------------------------------------------------------------------------------------------------- //---------------------------------------------------------------------------------------------------------------------
@ -117,7 +93,7 @@ void TST_MeasurementRegExp::TestMeasurementRegExp()
} }
case NoError: case NoError:
{ {
CheckNames(); CheckRegExpNames();
if (not pmsTranslator.isNull()) if (not pmsTranslator.isNull())
{ {
@ -395,6 +371,86 @@ void TST_MeasurementRegExp::TestCorrectOrderMeasurement()
QCOMPARE(name, expect); QCOMPARE(name, expect);
} }
//---------------------------------------------------------------------------------------------------------------------
void TST_MeasurementRegExp::TestAllTranslatedMeasurementsIsUnique_data()
{
PrepareMeasurementData();
}
//---------------------------------------------------------------------------------------------------------------------
void TST_MeasurementRegExp::TestAllTranslatedMeasurementsIsUnique()
{
QFETCH(QString, system);
QFETCH(QString, locale);
const int res = LoadTranslation(system, locale);
switch(res)
{
case ErrorInstall:
case ErrorSize:
case ErrorLoad:
{
const QString message = QString("Failed to check translation for system = %1 and locale = %2")
.arg(system)
.arg(locale);
QSKIP(qUtf8Printable(message));
break;
}
case NoError:
{
CheckIsNamesUnique();
if (not pmsTranslator.isNull())
{
const bool result = QCoreApplication::removeTranslator(pmsTranslator);
if (result == false)
{
const QString message = QString("Can't remove translation for system = %1 and locale = %2")
.arg(system)
.arg(locale);
QWARN(qUtf8Printable(message));
}
delete pmsTranslator;
}
break;
}
default:
QWARN("Unexpected state");
}
}
//---------------------------------------------------------------------------------------------------------------------
void TST_MeasurementRegExp::PrepareMeasurementData()
{
const int systemCounts = 56;
const QStringList locales = SupportedLocales();
{
const int combinations = systemCounts * locales.size();
QDir dir(TranslationsPath());
const QStringList fileNames = dir.entryList(QStringList("measurements_p*_*.qm"));
QVERIFY2(combinations == fileNames.size(), "Unexpected count of files.");
}
QTest::addColumn<QString>("system");
QTest::addColumn<QString>("locale");
for(int s = 0; s < systemCounts; ++s)
{
for(int l = 0, sz = locales.size(); l < sz; ++l)
{
const QString system = QString("p%1").arg(s);
const QString locale = locales.at(l);
const QString tag = QString("Check translation measurements_%1_%2.qm").arg(system).arg(locale);
QTest::newRow(qUtf8Printable(tag)) << system << locale;
}
}
}
//--------------------------------------------------------------------------------------------------------------------- //---------------------------------------------------------------------------------------------------------------------
int TST_MeasurementRegExp::LoadTranslation(const QString &checkedSystem, const QString &checkedLocale) int TST_MeasurementRegExp::LoadTranslation(const QString &checkedSystem, const QString &checkedLocale)
{ {
@ -462,7 +518,7 @@ void TST_MeasurementRegExp::InitTrMs()
} }
//--------------------------------------------------------------------------------------------------------------------- //---------------------------------------------------------------------------------------------------------------------
void TST_MeasurementRegExp::CheckNames() const void TST_MeasurementRegExp::CheckRegExpNames() const
{ {
const QStringList originalNames = AllGroupNames(); const QStringList originalNames = AllGroupNames();
const QRegularExpression re(NameRegExp()); const QRegularExpression re(NameRegExp());
@ -473,3 +529,17 @@ void TST_MeasurementRegExp::CheckNames() const
QCOMPARE(re.match(translated).hasMatch(), true); QCOMPARE(re.match(translated).hasMatch(), true);
} }
} }
//---------------------------------------------------------------------------------------------------------------------
void TST_MeasurementRegExp::CheckIsNamesUnique() const
{
const QStringList originalNames = AllGroupNames();
QSet<QString> names;
foreach(const QString &str, originalNames)
{
const QString translated = trMs->MToUser(str);
QCOMPARE(names.contains(translated), false);
names.insert(translated);
}
}

View File

@ -49,6 +49,8 @@ private slots:
void TestMeasurementRegExp(); void TestMeasurementRegExp();
void TestCorrectOrderMeasurement_data(); void TestCorrectOrderMeasurement_data();
void TestCorrectOrderMeasurement(); void TestCorrectOrderMeasurement();
void TestAllTranslatedMeasurementsIsUnique_data();
void TestAllTranslatedMeasurementsIsUnique();
private: private:
Q_DISABLE_COPY(TST_MeasurementRegExp) Q_DISABLE_COPY(TST_MeasurementRegExp)
@ -56,9 +58,11 @@ private:
QPointer<QTranslator> pmsTranslator; QPointer<QTranslator> pmsTranslator;
VTranslateMeasurements *trMs; VTranslateMeasurements *trMs;
void PrepareMeasurementData();
int LoadTranslation(const QString &checkedSystem, const QString &checkedLocale); int LoadTranslation(const QString &checkedSystem, const QString &checkedLocale);
void InitTrMs(); void InitTrMs();
void CheckNames() const; void CheckRegExpNames() const;
void CheckIsNamesUnique() const;
}; };
#endif // TST_MEASUREMENTREGEXP_H #endif // TST_MEASUREMENTREGEXP_H