aw/golang-image
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
164 Commits 1 Branch 2 Tags 8 MiB
9f8d0d4587
Commit Graph

7 Commits

Author SHA1 Message Date
Nigel Tao
0ebebfd658 webp: fix tests for webp/nycbcra deprecation. 
The previous commit (00fe24ef "webp/nycbcra: deprecate package") was
incomplete.

Change-Id: I6af5e1633b9c291e72b02877b308eae6e5624ef5
Reviewed-on: https://go-review.googlesource.com/21441
Reviewed-by: Nigel Tao <nigeltao@golang.org>
 2016-04-02 01:02:22 +00:00
Nigel Tao
7c492694a6 cmd/webp-manual-test: blacklist some versions of the dwebp binary. 
In particular, the 0.4.0 version of /usr/bin/dwebp that comes with
Ubuntu 14.04 LTS "Trusty", is known to be bad.

As per https://chromium.googlesource.com/webm/libwebp/+/master/NEWS
(grep for 239), versions 0.4.1 and 0.4.2 are also bad.

The alpha_color_cache.webp test file that triggers the discrepancy
between the (correct) Go implementation and the (buggy) libwebp C
implementation was added on 2015-01-23 in
f64fb2da01
in response to https://bugs.chromium.org/p/webp/issues/detail?id=239

Change-Id: Ifee19be0af634b9bf36ff0e16957648e05be840a
Reviewed-on: https://go-review.googlesource.com/18186
Reviewed-by: David Crawshaw <crawshaw@golang.org>
 2016-01-07 22:46:02 +00:00
Nigel Tao
95ece4346f cmd/webp-manual-test: add a "build ignore" tag, so that "go install 
golang.org/x/image/..." doesn't install the manual testing program.

Also add a missing copyright notice.

Change-Id: I7ab0a438df09ac8882e7d2482d2bf96d4260f8eb
Reviewed-on: https://go-review.googlesource.com/9277
Reviewed-by: Rob Pike <r@golang.org>
 2015-04-27 00:40:42 +00:00
David Symonds
0351284b2d image: add import comments. 
Change-Id: I2d3a1d002ad43af24cd8b451a2cae4c217482675
Reviewed-on: https://go-review.googlesource.com/1237
Reviewed-by: Andrew Gerrand <adg@golang.org>
 2014-12-09 22:43:18 +00:00
Andrew Gerrand
2e99ef522d go.image: use golang.org/x/... import paths 
LGTM=bradfitz, rsc
R=rsc, bradfitz
CC=golang-codereviews
https://golang.org/cl/169090043
 2014-11-10 08:52:14 +11:00
Nigel Tao
ef5e0288ce go.image/webp: implement lossy-with-alpha. 
This fixes all three lossy_alpha*.webp conformance tests.

The test data was generated by cwebp/dwebp version 0.4.1:
cwebp yellow_rose.png -o yellow_rose.lossy-with-alpha.webp
dwebp yellow_rose.lossy-with-alpha.webp -pgm -o tmp.pgm
convert tmp.pgm yellow_rose.lossy-with-alpha.webp.nycbcra.png

LGTM=pascal.massimino, r
R=r, pascal.massimino
CC=golang-codereviews
https://golang.org/cl/154350043
 2014-10-20 10:46:12 +11:00
Nigel Tao
96df300f7f go.image/cmd/webp-manual-test: new program to test Go's WEBP 
compatibility with the C libwebp implementation.

Current status:
104 PASS, 5 FAIL, 109 TOTAL
Of those 5 failures, 3 are because Go doesn't support lossy-with-alpha
yet, and the other 2 (lossless_vec_2_13.webp,
lossy_extreme_probabilities.webp) look like genuine bugs.

LGTM=r
R=r, pascal.massimino
CC=golang-codereviews
https://golang.org/cl/150000043
 2014-09-25 09:44:20 +10:00