Fix: forgot to (*Client)GetNotification's parameter: int64 -> ID

This commit is contained in:
Kaoru HAYAMA 2017-10-25 14:35:34 +09:00
parent 74f003d4a4
commit fe913e01e5
2 changed files with 6 additions and 6 deletions

View File

@ -27,9 +27,9 @@ func (c *Client) GetNotifications(ctx context.Context, pg *Pagination) ([]*Notif
}
// GetNotification return notification.
func (c *Client) GetNotification(ctx context.Context, id int64) (*Notification, error) {
func (c *Client) GetNotification(ctx context.Context, id ID) (*Notification, error) {
var notification Notification
err := c.doAPI(ctx, http.MethodGet, fmt.Sprintf("/api/v1/notifications/%d", id), nil, &notification, nil)
err := c.doAPI(ctx, http.MethodGet, fmt.Sprintf("/api/v1/notifications/%v", id), nil, &notification, nil)
if err != nil {
return nil, err
}

View File

@ -40,17 +40,17 @@ func TestGetNotifications(t *testing.T) {
t.Fatalf("result should be two: %d", len(ns))
}
if ns[0].ID != "122" {
t.Fatalf("want %v but %v", 122, ns[0].ID)
t.Fatalf("want %v but %v", "122", ns[0].ID)
}
if ns[1].ID != "123" {
t.Fatalf("want %v but %v", 123, ns[1].ID)
t.Fatalf("want %v but %v", "123", ns[1].ID)
}
n, err := client.GetNotification(context.Background(), 123)
n, err := client.GetNotification(context.Background(), "123")
if err != nil {
t.Fatalf("should not be fail: %v", err)
}
if n.ID != "123" {
t.Fatalf("want %v but %v", 123, n.ID)
t.Fatalf("want %v but %v", "123", n.ID)
}
err = client.ClearNotifications(context.Background())
if err != nil {